Conversation
|
Report: Report: api - scala:2.12.17
|
ABLL526
approved these changes
Apr 23, 2026
Collaborator
ABLL526
left a comment
There was a problem hiding this comment.
Seems good to me, but 10 seconds as default seems quite long. Any reason for that?
Collaborator
Author
Well, the original default of 500ms was tested to be too short in our DEV env, so this is just to make sure that we have enough. I hardly see any downside - the users rather want to be logged in while waiting slightly longer than not at all. It is still a overridable default, though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #160 with overridable config values (provided sensible defaults of 10s).
Tested on DEV, got a LS token from Entra token.
Release notes:
loginsvc.rest.auth.provider.entra.{jwks-connect-timeout-ms, jwks-read-timeout-ms}Closes #161