Skip to content

Bugfix/161 entra timeouts#162

Merged
dk1844 merged 4 commits intomasterfrom
bugfix/161-entra-timeouts
Apr 23, 2026
Merged

Bugfix/161 entra timeouts#162
dk1844 merged 4 commits intomasterfrom
bugfix/161-entra-timeouts

Conversation

@dk1844
Copy link
Copy Markdown
Collaborator

@dk1844 dk1844 commented Apr 23, 2026

Fixes #160 with overridable config values (provided sensible defaults of 10s).

Tested on DEV, got a LS token from Entra token.

Release notes:

  • Entra timeouts are now 10s/10s by default, configurable by loginsvc.rest.auth.provider.entra.{jwks-connect-timeout-ms, jwks-read-timeout-ms}

Closes #161

@dk1844 dk1844 requested a review from jakipatryk as a code owner April 23, 2026 13:57
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 23, 2026

Report: Report: api - scala:2.12.17

Metric (instruction) Coverage Threshold Status
Overall 71.22% 43.0%
Changed Files 68.29% 70.0%
File Path Coverage Threshold Status
MsEntraConfig.scala 70.11% 0.0%
MsEntraTokenValidator.scala 66.47% 0.0%

Copy link
Copy Markdown
Collaborator

@ABLL526 ABLL526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me, but 10 seconds as default seems quite long. Any reason for that?

@dk1844
Copy link
Copy Markdown
Collaborator Author

dk1844 commented Apr 23, 2026

Seems good to me, but 10 seconds as default seems quite long. Any reason for that?

Well, the original default of 500ms was tested to be too short in our DEV env, so this is just to make sure that we have enough. I hardly see any downside - the users rather want to be logged in while waiting slightly longer than not at all. It is still a overridable default, though.

@dk1844 dk1844 merged commit a8b9225 into master Apr 23, 2026
4 of 8 checks passed
@dk1844 dk1844 deleted the bugfix/161-entra-timeouts branch April 24, 2026 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MS Entra plugin times out sometimes

2 participants