Skip to content

add shutdown wrapper and node config knobs#24

Merged
coffeexcoin merged 1 commit intomainfrom
bump-node
Apr 24, 2026
Merged

add shutdown wrapper and node config knobs#24
coffeexcoin merged 1 commit intomainfrom
bump-node

Conversation

@coffeexcoin
Copy link
Copy Markdown
Contributor

@coffeexcoin coffeexcoin commented Apr 24, 2026

PR-Codex overview

This PR focuses on updating the abstract-node Helm chart, including a version bump and several new configuration options for shutdown behavior, RPC response size, and database connection pooling.

Detailed summary

  • Bumped version in Chart.yaml from 0.1.36 to 0.1.37.
  • Added shutdownWrapper configuration in values.yaml with enabled set to false.
  • Introduced maxResponseBodySizeMb in values.yaml.
  • Added poolSize and poolSizeMaster options in values.yaml.
  • Modified statefulset.yaml to use shutdownWrapper.enabled for command execution.
  • Added handling for signals in the shutdown wrapper script.
  • Updated environment variables in statefulset.yaml to include new values for EN_MAX_RESPONSE_BODY_SIZE_MB and EN_DATABASE_MAX_CONNECTIONS_MASTER.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@coffeexcoin coffeexcoin merged commit 288215e into main Apr 24, 2026
1 check passed
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d6184eed47

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +95 to +97
status=0
wait "$child" || status=$?
exit "$status"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Continue waiting after trapped termination signal

When shutdownWrapper.enabled is true and Kubernetes sends SIGTERM, the trap forwards SIGINT to the child, but in /bin/sh the wait call is interrupted and returns a signal status (commonly 143). This code then exits immediately with that status instead of waiting for the child to finish shutdown, so PID 1 terminates early and the external node can be killed before graceful cleanup completes. Keep waiting (or retry wait) after trapped signals until the child actually exits.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant