add shutdown wrapper and node config knobs#24
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d6184eed47
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| status=0 | ||
| wait "$child" || status=$? | ||
| exit "$status" |
There was a problem hiding this comment.
Continue waiting after trapped termination signal
When shutdownWrapper.enabled is true and Kubernetes sends SIGTERM, the trap forwards SIGINT to the child, but in /bin/sh the wait call is interrupted and returns a signal status (commonly 143). This code then exits immediately with that status instead of waiting for the child to finish shutdown, so PID 1 terminates early and the external node can be killed before graceful cleanup completes. Keep waiting (or retry wait) after trapped signals until the child actually exits.
Useful? React with 👍 / 👎.
PR-Codex overview
This PR focuses on updating the
abstract-nodeHelm chart, including a version bump and several new configuration options for shutdown behavior, RPC response size, and database connection pooling.Detailed summary
versioninChart.yamlfrom0.1.36to0.1.37.shutdownWrapperconfiguration invalues.yamlwithenabledset tofalse.maxResponseBodySizeMbinvalues.yaml.poolSizeandpoolSizeMasteroptions invalues.yaml.statefulset.yamlto useshutdownWrapper.enabledfor command execution.statefulset.yamlto include new values forEN_MAX_RESPONSE_BODY_SIZE_MBandEN_DATABASE_MAX_CONNECTIONS_MASTER.