Skip to content

Add XYZ-to-working-space transform for hardware shaders#3005

Open
r800360 wants to merge 1 commit into
AcademySoftwareFoundation:mainfrom
r800360:fix/xyz-to-working-space
Open

Add XYZ-to-working-space transform for hardware shaders#3005
r800360 wants to merge 1 commit into
AcademySoftwareFoundation:mainfrom
r800360:fix/xyz-to-working-space

Conversation

@r800360

@r800360 r800360 commented Jul 14, 2026

Copy link
Copy Markdown

Fixes #2859

Summary

  • Adds GenOptions::xyzToWorkingSpace, defaulting to the CIE XYZ to lin_rec709 transform.
  • Exposes the transform as the private hardware-shader uniform u_xyzToWorkingSpace.
  • Uses the uniform for blackbody emission and thin-film iridescence.
  • Removes the two hardcoded XYZ-to-RGB matrices.
  • Adds a focused GLSL shader-generation test covering the default transform, custom overrides, private-uniform propagation, token substitution, and both shader consumers.

Testing

  • MaterialXTest "GenShader: GLSL XYZ to Working Space"
  • Full MaterialXTest suite
  • 65 test cases and 14,579 assertions passed

@linux-foundation-easycla

linux-foundation-easycla Bot commented Jul 14, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: r800360 / name: Rohan Sachdeva (803f959)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Color-space awareness in thin-film iridescence and blackbody emission

1 participant