MaterialX Graph Editor : Fix keyboard input for graph#3012
Open
kwokcb wants to merge 1 commit into
Open
Conversation
- Parenting was added without updaring event logic. - Add firewall checks to make sure that property editor and menu events are not considered. - All keyinput tested manually.
kwokcb
changed the title
kwokcb
commented
Jul 23, 2026
| ImGuiIO& guiIO = ImGui::GetIO(); | ||
| if (guiIO.KeyCtrl && !_fileDialogSave.isOpened() && !_fileDialog.isOpened() && !_fileDialogGeom.isOpened()) | ||
| if (guiIO.KeyCtrl && | ||
| !guiIO.WantTextInput && |
Contributor
Author
There was a problem hiding this comment.
WantTextInput() added in various places to avoid text input / graph hotkey collisions. Used along with focus tests.
| { | ||
| const bool open_search = ImGui::IsWindowFocused(ImGuiFocusedFlags_RootAndChildWindows) && ImGui::IsKeyDown(ImGuiKey_F) && ImGui::IsKeyDown(ImGuiKey_LeftCtrl); | ||
| const ImGuiIO& io = ImGui::GetIO(); | ||
| const bool open_search = ImGui::IsWindowFocused(ImGuiFocusedFlags_RootAndChildWindows) && |
Contributor
Author
There was a problem hiding this comment.
Must consider children since graph editor and property editor are now children not directly at root.
| // Keep ctrl-click state frame-local; stale true blocks connection copy in paste. | ||
| _ctrlClick = io2.KeyCtrl && io2.MouseDown[0]; | ||
|
|
||
| const bool graphShortcutContext = |
Contributor
Author
There was a problem hiding this comment.
Robust hotkey filtering checking for graphing area.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes: #3010
Fixes
Testing