Fix oapv_bsw_write1() to add necessary typecast#189
Merged
kpchoi merged 1 commit intoAcademySoftwareFoundation:mainfrom Feb 19, 2026
Merged
Fix oapv_bsw_write1() to add necessary typecast#189kpchoi merged 1 commit intoAcademySoftwareFoundation:mainfrom
kpchoi merged 1 commit intoAcademySoftwareFoundation:mainfrom
Conversation
13d6308 changed the bitstream parse and write functions to use a 64bit variable in the bitstream structure. In that CL, oapv_bsw_write() was updated to typecast the value being written before shifting but, but oapv_bsw_write1() wasn't updated. This CL updates oapv_bsw_write1() to add the necessary typecast to u64. Signed-off-by: Harish Mahendrakar <harish.mahendrakar@ittiam.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
13d6308 changed the bitstream parse and write functions to use a 64bit variable in the bitstream structure.
In that CL, oapv_bsw_write() was updated to typecast the value being written before shifting but, but oapv_bsw_write1() wasn't updated.
This CL updates oapv_bsw_write1() to add the necessary typecast to u64.