Fix missing packed/unpacked size guard in scanline chunk reader#2536
Open
cary-ilm wants to merge 1 commit into
Open
Fix missing packed/unpacked size guard in scanline chunk reader#2536cary-ilm wants to merge 1 commit into
cary-ilm wants to merge 1 commit into
Conversation
PR AcademySoftwareFoundation#2162 added a check to reject uncompressed chunks where packed_size != unpacked_size in exr_read_tile_chunk_info, but the equivalent check was missing from exr_read_scanline_chunk_info. A crafted uncompressed deep-scanline EXR with a mismatched packed_size caused the decoder to allocate an unpacked_buffer via malloc that was never filled, leaking stale heap contents into caller-visible pixels. Addresses https://github.com/AcademySoftwareFoundation/openexr/security/advisories/GHSA-9c7r-mp54-x46f Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Cary Phillips <cary@ilm.com>
peterhillman
left a comment
peterhillman
left a comment
Collaborator
There was a problem hiding this comment.
Is this the same as #2548?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #2162 added a check to reject uncompressed chunks where packed_size != unpacked_size in exr_read_tile_chunk_info, but the equivalent check was missing from exr_read_scanline_chunk_info. A crafted uncompressed deep-scanline EXR with a mismatched packed_size caused the decoder to allocate an unpacked_buffer via malloc that was never filled, leaking stale heap contents into caller-visible pixels.
Addresses https://github.com/AcademySoftwareFoundation/openexr/security/advisories/GHSA-9c7r-mp54-x46f