Skip to content

Reject oversized exrmetrics vector allocations on ILP32 #2539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cary-ilm merged 2 commits into from
Jul 14, 2026
+26 −6
Merged

Reject oversized exrmetrics vector allocations on ILP32 #2539

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d7d959
Reject oversized exrmetrics vector allocations on ILP32
cary-ilm Jul 11, 2026
fc8575d
Merge branch 'main' into fix-exrmetrics-ilp32
cary-ilm Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 26 additions & 6 deletions src/bin/exrmetrics/exrmetrics.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@

#include <chrono>
#include <ctime>
#include <limits>
#include <list>
#include <stdexcept>
#include <vector>
Expand All @@ -46,6 +47,25 @@ using std::vector;
using std::chrono::steady_clock;
using std::isinf;

namespace {

//
// Validate that count*sampleSize casts to size_t without overflow, before
// using the value to resize a std::vector.
//

size_t
vectorSize (uint64_t count, int sampleSize = 1)
{
const uint64_t sampleSizeU = static_cast<uint64_t> (sampleSize);
const uint64_t maxSize = std::numeric_limits<size_t>::max ();
if (sampleSizeU > 0 && count > maxSize / sampleSizeU)
throw IEX_NAMESPACE::OverflowExc ("Integer multiplication overflow.");
return static_cast<size_t> (count * sampleSizeU);
}

} // namespace

double
timing (steady_clock::time_point start, steady_clock::time_point end)
{
Expand Down Expand Up @@ -92,7 +112,7 @@ initScanLine (
size_t pixelsInChannel = (width / i.channel ().xSampling) *
(height / i.channel ().ySampling);
rawSize += pixelsInChannel * samplesize;
pixelData[channelNumber].resize (numPixels * samplesize);
pixelData[channelNumber].resize (vectorSize (numPixels, samplesize));

buf.insert (
i.name (),
Expand Down Expand Up @@ -205,7 +225,7 @@ initTiled (
{
int samplesize = pixelTypeSize (i.channel ().type);
pixelData[levelIndex][channelNumber].resize (
numPixels * samplesize);
vectorSize (numPixels, samplesize));

buf[levelIndex].insert (
i.name (),
Expand Down Expand Up @@ -324,7 +344,7 @@ initAndReadDeepScanLine (
uint64_t height = dw.max.y + 1 - dw.min.y;
uint64_t numPixels = width * height;
int numChans = channelCount (in.header ());
sampleCount.resize (numPixels);
sampleCount.resize (vectorSize (numPixels));

uint64_t offsetToOrigin = width * static_cast<uint64_t> (dw.min.y) +
static_cast<uint64_t> (dw.min.x);
Expand All @@ -342,7 +362,7 @@ initAndReadDeepScanLine (
i != outHeader.channels ().end ();
++i)
{
pixelPtrs[channelNumber].resize (numPixels);
pixelPtrs[channelNumber].resize (vectorSize (numPixels));
int samplesize = pixelTypeSize (i.channel ().type);
buf.insert (
i.name (),
Expand Down Expand Up @@ -492,7 +512,7 @@ initAndReadDeepTiled (
static_cast<uint64_t> (dw.min.x);

pixelPtrs.resize (numChans);
sampleCount.resize (numPixels);
sampleCount.resize (vectorSize (numPixels));

buf.insertSampleCountSlice (Slice (
UINT,
Expand All @@ -506,7 +526,7 @@ initAndReadDeepTiled (
i != outHeader.channels ().end ();
++i)
{
pixelPtrs[channelNumber].resize (numPixels);
pixelPtrs[channelNumber].resize (vectorSize (numPixels));
int samplesize = pixelTypeSize (i.channel ().type);
buf.insert (
i.name (),
Expand Down
Loading