Fix for an occaisional crash when swapping a media_source's URI#210
Merged
tedwaine merged 1 commit intoAcademySoftwareFoundation:developfrom Feb 23, 2026
Merged
Conversation
…nging the URI of the currently viewed media_source. This seemed the safest fix although there are others I tried but I was worried about the potential impact on performance. Signed-off-by: Ken McGaugh <ken@mcgaugh.co.uk>
tedwaine
merged commit 9340aea
into
AcademySoftwareFoundation:develop
2 of 3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an occasional crash I was getting when changing the URI on the currenly viewed media_source. The crash was caused by an uncaught exception on line 1430 where
media_streams_.at(base_.current(media_type))is called. The existence of that entry is tested in the calling lambda but it was changing before this attempt at accessing it.Repeating the test seemed to be the safest fix although there are other ways of addressing this.