Windows path fixes#214
Merged
tedwaine merged 5 commits intoAcademySoftwareFoundation:developfrom Feb 23, 2026
Merged
Conversation
Use os.pathsep instead of hardcoded ":" to split XSTUDIO_PYTHON_PLUGIN_PATH, since Windows uses ";" as the path separator and ":" would break drive letters. Signed-off-by: Ben De Luca <bdeluca@gmail.com>
Env var values can contain trailing whitespace depending on how they are set (e.g. cmd.exe "set VAR=value && cmd"), causing path lookups to fail. Signed-off-by: Ben De Luca <bdeluca@gmail.com>
Use generic_string() instead of string() for directory entries. path::string() returns OS-native separators (backslashes on Windows), while the regex is built from URI-decoded paths that use forward slashes. generic_string() always returns forward slashes, so the regex matches correctly. Signed-off-by: Ben De Luca <bdeluca@gmail.com>
Add proper UNC path support for Windows: - posix_path_to_uri: Convert \\server\share\path to file://server/share/path - uri_to_posix_path: Reconstruct \\server\share\path from file://server/share/path This fixes drag-and-drop of image sequences from network shares on Windows. Also fix a pre-existing bug where reverse_remap_file_path was called on the original input parameter instead of the working copy, discarding any transformations applied earlier in the function. Signed-off-by: Ben De Luca <bdeluca@gmail.com>
On Windows, paths like R:\foo were passed directly to the URI builder without normalising backslashes or prepending a leading slash, producing invalid file URIs. Normalise to forward slashes and prepend / for drive-letter paths so they produce correct file:///R:/foo URIs. Signed-off-by: Ben De Luca <bdeluca@gmail.com>
bdeluca
force-pushed
the
pr/windows-path-fixes
branch
from
2a2f6d1 to
bc2d80b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issues
Fixes #213
Fixes #110
Summarize your change.
Windows Path fixes, issues with UNC, Drive letters, and XSTUDIO_PYTHON_PLUGIN_PATH
Describe the reason for the change.
Better windows support
Describe what you have tested and on which operating system.
lin/win
Add a list of changes, and note any that might need special attention during the review.