Skip to content

fix: simplify workflow import - only trigger for new users#64

Merged
acedatacloud-dev merged 1 commit intomainfrom
fix/simplify-workflow-import
Mar 14, 2026
Merged

fix: simplify workflow import - only trigger for new users#64
acedatacloud-dev merged 1 commit intomainfrom
fix/simplify-workflow-import

Conversation

@acedatacloud-dev
Copy link

Changes

  • Remove is_new_user parameter from _persist_acedatacloud_token - that function only handles token persistence now
  • Only fire import task for new users - moved task call to OAuth callback, guarded by oauth_new_user. No more wasteful Celery tasks on every login
  • Fix retry bug - old except Exception swallowed all exceptions, making autoretry_for dead code. Retries now work correctly
  • Fix Explore setup - old _ensure_explore_apps imported into any user's workspace as side effect. New _register_explore_apps only looks up already-imported apps
  • Parse YAML once - extracted _parse_workflow_yaml helper

Copy link
Member

@Germey Germey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acedatacloud-dev acedatacloud-dev merged commit ba70d20 into main Mar 14, 2026
10 of 11 checks passed
@acedatacloud-dev acedatacloud-dev deleted the fix/simplify-workflow-import branch March 14, 2026 13:41
@github-actions
Copy link

Pyrefly Diff

base → PR
3256c3256
<   --> tasks/import_acedatacloud_workflow_templates_task.py:86:5
---
>   --> tasks/import_acedatacloud_workflow_templates_task.py:84:5
3258c3258
< 86 |     account.current_tenant_id = tenant_id
---
> 84 |     account.current_tenant_id = tenant_id

1 similar comment
@github-actions
Copy link

Pyrefly Diff

base → PR
3256c3256
<   --> tasks/import_acedatacloud_workflow_templates_task.py:86:5
---
>   --> tasks/import_acedatacloud_workflow_templates_task.py:84:5
3258c3258
< 86 |     account.current_tenant_id = tenant_id
---
> 84 |     account.current_tenant_id = tenant_id

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants