This repository was archived by the owner on Oct 12, 2023. It is now read-only.
Add replicaset support#18
Open
smoliji wants to merge 9 commits into
Open
Conversation
Contributor
smoliji
commented
Sep 16, 2020
smoliji
commented
- adds multiple replica support based on Documentation: Read/Write Replica Configuration Patterns and Best Practices (WAS: Customize connection pool and/or queries for cluster instances) knex/knex#2253 (comment)
akrivohlavy
reviewed
Sep 29, 2020
akrivohlavy
reviewed
Sep 29, 2020
akrivohlavy
reviewed
Sep 29, 2020
| }; | ||
|
|
||
| exports.isWriteBuilder = (builder) => { | ||
| // Enable query context override: knex.select('*').queryContext({ replicaNode: 'write' | 'read' }) |
Contributor
There was a problem hiding this comment.
Can this be passed via repostitory method options?
repo.detail({ id : 1 }, { queryContext: { replicaNode: 'write' } })
Contributor
Author
There was a problem hiding this comment.
I am afraid not, these options are passed to Bookshelf directly, but BS doesn't seem to pass these options directly below to Knex.
For now you can use:
repo.detail({ id : 1 }, { qb => qb.queryContext({ replicaNode: 'write' }) } )Or I can make shortcut for the reposutory to set it via repository option queryContext as you suggested.
akrivohlavy
reviewed
Sep 29, 2020
Co-authored-by: Antonín Křivohlavý <antonin.krivohlavy@ackee.cz>
Co-authored-by: Antonín Křivohlavý <antonin.krivohlavy@ackee.cz>
Contributor
Author
|
@vlasy you use this revision on one of your projects - is there anything blocking the merge and release? |
noref #0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.