feat: add editor and UI zoom commands#2058
feat: add editor and UI zoom commands#2058bajrangCoder merged 4 commits intoAcode-Foundation:mainfrom
Conversation
Greptile SummaryThis PR adds two new features: an editor font-size zoom accessible via Confidence Score: 4/5Safe to merge with minor caveats — no data loss or security concerns, but the Ctrl-+ terminal binding dead-end and the bundled indentGuides default change are worth resolving. All P1/P0-level concerns were already flagged in prior review rounds and appear addressed in the current code. Remaining new findings are P2: a dead Ctrl-+ alternative in the terminal binding lookup, a misleading || 100 fallback, and an unrelated indentGuides default flip bundled into the PR. src/components/terminal/terminal.js — Ctrl-+ alternative is unreachable; src/lib/settings.js and src/lib/editorManager.js — unrelated indentGuides default change. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[User action] --> B{Source}
B -->|Settings UI| C[appSettings.js callback]
B -->|Command: increaseUiZoom / decreaseUiZoom| D[adjustUiZoom in commandRegistry.js]
B -->|App startup| E[applySettings.js]
C --> C1[Validate: integer, 70-160]
C1 -->|invalid| X[return - silent drop]
C1 -->|valid| C2[appSettings.update uiZoom]
C2 --> F
D --> D1[Clamp to 70-160]
D1 --> D2[settings.value.uiZoom = next]
D2 --> D3[settings.update false]
D3 --> F
E --> F
F[Settings.applyUiZoomSetting] --> G{uiZoomBaseFontSize cached?}
G -->|No - first call| H[Read getComputedStyle fontSize]
H --> I[Cache baseline]
G -->|Yes| I
I --> J[Apply rootFontSize x zoom/100 as inline style]
J --> K[Clear window.root CSS zoom]
Reviews (2): Last reviewed commit: "fix" | Re-trigger Greptile |
No description provided.