Skip to content

fix: f-string fix in query#91

Closed
0xbrayo wants to merge 1 commit intoActivityWatch:masterfrom
0xbrayo:master
Closed

fix: f-string fix in query#91
0xbrayo wants to merge 1 commit intoActivityWatch:masterfrom
0xbrayo:master

Conversation

@0xbrayo
Copy link
Copy Markdown
Member

@0xbrayo 0xbrayo commented Aug 8, 2025

Important

Changed string concatenation to f-string in fullDesktopQuery() in queries.py.

  • Code Improvement:
    • Changed string concatenation to f-string in fullDesktopQuery() in queries.py for browser-related query parts.

This description was created by Ellipsis for 76a1ecb. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Copy Markdown

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 76a1ecb in 35 seconds. Click for details.
  • Reviewed 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. aw_client/queries.py:264
  • Draft comment:
    Using an f-string here allows for proper interpolation of variables (e.g. {default_limit}). The change is correct - ensure that any literal curly braces (if present) are escaped if needed.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is informative, explaining the use of f-strings and suggesting to escape curly braces if needed. However, it doesn't ask for a specific action or suggest a change. It doesn't fit the criteria for a useful comment as it doesn't provide a specific suggestion or ask for confirmation on a specific issue.

Workflow ID: wflow_0eVhKTS6zgdm9j76

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@0xbrayo 0xbrayo closed this Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant