ci: fix build workflow for modern GitHub Actions runners#120
ci: fix build workflow for modern GitHub Actions runners#120ErikBjare merged 3 commits intoActivityWatch:masterfrom
Conversation
- ubuntu-20.04 removed from GitHub Actions (all jobs stuck in queued) → use ubuntu-22.04 - macOS-13 → macos-latest (includes Apple Silicon) - Python 3.9 (EOL) → 3.11 - actions/checkout v3 → v4, actions/setup-python v4 → v5 - Replace qt5-default (nonexistent on Ubuntu 22.04+) with Qt6 runtime deps (libxcb-cursor0, libfontconfig1, libegl1) - Add apt-get update before install Fixes ActivityWatch#118
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to e5e89bc in 8 seconds. Click for details.
- Reviewed
34lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_tSs8aGSvsI6Fz5On
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
PyQt6 bundles its own Qt xcb platform plugin which links against several xcb extension libraries. Just libxcb-cursor0 is not enough — the full set of xcb dependencies is needed for the plugin to load.
Greptile SummaryUpdates CI workflow to use modern GitHub Actions runners and dependencies. Changes address the removal of Confidence Score: 4/5
Important Files Changed
Last reviewed commit: ca368b7 |
…ch#120) * ci: fix build workflow for modern GitHub Actions runners - ubuntu-20.04 removed from GitHub Actions (all jobs stuck in queued) → use ubuntu-22.04 - macOS-13 → macos-latest (includes Apple Silicon) - Python 3.9 (EOL) → 3.11 - actions/checkout v3 → v4, actions/setup-python v4 → v5 - Replace qt5-default (nonexistent on Ubuntu 22.04+) with Qt6 runtime deps (libxcb-cursor0, libfontconfig1, libegl1) - Add apt-get update before install Fixes ActivityWatch#118 * ci: add missing xcb libraries for PyQt6 on Ubuntu PyQt6 bundles its own Qt xcb platform plugin which links against several xcb extension libraries. Just libxcb-cursor0 is not enough — the full set of xcb dependencies is needed for the plugin to load. --------- Co-authored-by: Erik Bjäreholt <erik@bjareho.lt>
Summary
ubuntu-20.04was removed from GitHub Actions, causing all CI jobs to be stuck in "queued" indefinitelyubuntu-22.04,macos-latest, Python 3.11, and latest action versionsqt5-default(nonexistent on Ubuntu 22.04+) with Qt6 runtime dependenciesFixes #118
Changes
ubuntu-20.04ubuntu-22.04macOS-13macos-latestactions/checkout@v3@v4actions/setup-python@v4@v5qt5-defaultlibxcb-cursor0 libfontconfig1 libegl1Test plan
Important
Update CI workflow to use
ubuntu-22.04,macos-latest, Python 3.11, and latest GitHub Actions versions, replacing deprecated dependencies.ubuntu-20.04toubuntu-22.04andmacOS-13tomacos-latestinbuild.yml.actions/checkouttov4andactions/setup-pythontov5.qt5-defaultwithlibxcb-cursor0,libfontconfig1, andlibegl1for Qt6 compatibility on Linux.This description was created by
for e5e89bc. You can customize this summary. It will automatically update as commits are pushed.