Skip to content

Autodetect modules#27

Closed
ErikBjare wants to merge 6 commits into
masterfrom
dev/autodetect-modules
Closed

Autodetect modules#27
ErikBjare wants to merge 6 commits into
masterfrom
dev/autodetect-modules

Conversation

@ErikBjare
Copy link
Copy Markdown
Member

@ErikBjare ErikBjare commented Aug 30, 2017 •
edited
Loading

This is a nice one.

  • Detects modules in the users PATH (executables must contain "aw-")
  • Detects modules bundled with aw-qt (in the same directory)

This makes it a lot easier to run manage whichever module/watcher you want with aw-qt.

@ErikBjare ErikBjare mentioned this pull request Aug 30, 2017
Closed
@ErikBjare
Copy link
Copy Markdown
Member Author

ErikBjare commented Sep 1, 2017

I'm probably going to go ahead and merge this when the macOS build is done.

@ErikBjare
Copy link
Copy Markdown
Member Author

ErikBjare commented Sep 1, 2017 •
edited
Loading

I just realized that PyInstaller might mess up when you try to run system modules since it modifies LD_LIBRARY_PATH either directly or indirectly (since its likely to search the working directory).

  • Check that it handles system modules properly

@ErikBjare ErikBjare mentioned this pull request Jul 3, 2018
Closed
@ErikBjare
Copy link
Copy Markdown
Member Author

ErikBjare commented Jul 3, 2018

  • Also, should probably test this on Windows where things might behave differently.

ErikBjare
ErikBjare commented Jul 3, 2018
View reviewed changes
Comment thread aw_qt/manager.py


def _discover_modules_system() -> List[str]:
search_paths = os.environ["PATH"].split(":")
Copy link
Copy Markdown
Member Author

@ErikBjare ErikBjare Jul 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PATH might not be defined on Windows

@ErikBjare ErikBjare mentioned this pull request Sep 11, 2018
Open
@sanderboom
Copy link
Copy Markdown

sanderboom commented Sep 28, 2018

This would be a sweet addition!

I'm probably going to go ahead and merge this when the macOS build is done.

And it was almost done? What's the holdup? Should I test under Window$?

@ErikBjare ErikBjare mentioned this pull request Nov 6, 2019
Closed
@ErikBjare
Copy link
Copy Markdown
Member Author

ErikBjare commented Nov 6, 2019

Yeah testing on Windows (and macOS, but should be fine) is the blocker.

@johan-bjareholt johan-bjareholt mentioned this pull request Jan 7, 2020
Merged
4 tasks
@ErikBjare ErikBjare mentioned this pull request Mar 2, 2020
Merged
3 tasks
@ErikBjare
Copy link
Copy Markdown
Member Author

ErikBjare commented Apr 19, 2020

Closing in favor of #56

@ErikBjare ErikBjare closed this Apr 19, 2020
vasuemme111 pushed a commit to Ralvie-AI/aw-qt that referenced this pull request Apr 24, 2024
@ErikBjare
allow the macOS build to fail (issue ActivityWatch#27)
fb772b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

in progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ErikBjare @sanderboom @johan-bjareholt