Skip to content

feat: add Safari browser support #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
F1Justin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add Safari browser support #791

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/queries.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,7 @@ const browser_appnames: Record<string, string[]> = {
zen: ['app.zen_browser.zen'],
floorp: ['one.ablaze.floorp'],
helium: ['net.imput.helium'],
safari: ['com.apple.Safari'],
};

// Returns a list of (browserName, bucketId) pairs for found browser buckets
Expand Down Expand Up @@ -275,6 +276,7 @@ export const browser_appname_regex: Record<string, string> = {
zen: '(?i)(zen)',
floorp: '(?i)(floorp)',
helium: '(?i)(helium)',
safari: '(?i)^safari(浏览器)?$',
};

// Returns a list of active browser events (where the browser was the active window) from all browser buckets
Expand Down
9 changes: 9 additions & 0 deletions test/unit/queries.test.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,4 +230,13 @@ describe('browser_appname_regex', () => {
expect(re.test(name)).toBe(true);
}
});

test('safari pattern matches known Safari app names', () => {
const re = toRegex(browser_appname_regex.safari);
expect(re.test('Safari')).toBe(true);
expect(re.test('safari')).toBe(true);
expect(re.test('Safari浏览器')).toBe(true); // macOS Chinese localization
// Should not match unrelated apps
expect(re.test('SafariBrowser')).toBe(false);
});
});
Loading