Sherman Christina, TREK#44
Open
Peacegypsy wants to merge 12 commits intoAda-C10:masterfrom
Open
Conversation
added 12 commits
November 20, 2018 16:37
… alt way to show trip info
TREKWhat We're Looking For
|
CheezItMan
reviewed
Nov 28, 2018
| const individualTrip = showTrip(trip.id); | ||
| vacation.click(individualTrip); | ||
| }) | ||
| .catch(error => { |
There was a problem hiding this comment.
You have the catch after the forEach. Instead move the }) on line 45, up to before the .catch
You can see the error in your browser console
| }) | ||
| .catch(error => { | ||
| console.log(error.response); | ||
| if (error.response.data && error.response.data.errors) { |
There was a problem hiding this comment.
If the post doesn't work (network error), then there may be no error.response (it may be undefined).
This should be:
if (error.response && error.response.data && error.response.data.errors) {
CheezItMan
reviewed
Nov 28, 2018
| }) | ||
| .catch(error => { | ||
| console.log(error.response); | ||
| if (error.response.data && error.response.data.errors) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TREK
Congratulations! You're submitting your assignment!
Comprehension Questions
Tripin the list by it's ID field. Would it be advantageous to keep the list in order by the id field? Explain why or why not.