Branches - Brianna#1
Open
brikemp wants to merge 4 commits intoAda-C12:masterfrom
Open
Conversation
CheezItMan
reviewed
Mar 18, 2020
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nicely done, you hit the learning goals here. Awesome work. Do take a look at my comments on time/space complexity. Otherwise well done.
Comment on lines
4
to
7
| // Time Complexity: O(log n) | ||
| // Space Complexity: O(n) | ||
|
|
||
| function heapsort(list) { |
There was a problem hiding this comment.
You're adding n elements to a heap (each add is log n) and so this sort is O(n log n) time complexity.
Comment on lines
+55
to
57
| // Time complexity: O(1) | ||
| // Space complexity: O(1) | ||
| isEmpty() { |
Comment on lines
+80
to
82
| // Time complexity: O(log n) - n: nodes in heap | ||
| // Space complexity: O(log n) or O(1)? | ||
| heapDown(index) { |
There was a problem hiding this comment.
For space complexity are you creating any new data structures? Are you making recursive calls? If not it's O(1).
Otherwise this works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heaps Practice
Congratulations! You're submitting your assignment!
Comprehension Questions
heap_up&heap_downmethods useful? Why?