Branches - Emily Ball#39
Open
eaball35 wants to merge 4 commits intoAda-C12:masterfrom
Open
Conversation
CheezItMan
reviewed
Mar 10, 2020
CheezItMan
left a comment
There was a problem hiding this comment.
You have some minor issues with Queue, but otherwise this is very well done. Nice work! You hit all the major learning goals here. Well done.
Comment on lines
+3
to
5
| # Time Complexity: O(n) where n is characters in string | ||
| # Space Complexity: O(n) where n is characters in string | ||
| def balanced(string) |
| @back = -1 | ||
| end | ||
|
|
||
| def enqueue(element) |
| @back = (@back + 1) % @store.length | ||
| end | ||
|
|
||
| def dequeue |
| def front | ||
| raise NotImplementedError, "Not yet implemented" | ||
| return nil if empty? | ||
| return @front |
There was a problem hiding this comment.
Suggested change
| return @front | |
| return @stores[@front] |
Comment on lines
+44
to
+45
| return @front - @back if @front > @back | ||
| return @back + (@store.length - @front) |
There was a problem hiding this comment.
I think you have this reversed here.
Suggested change
| return @front - @back if @front > @back | |
| return @back + (@store.length - @front) | |
| return @back - @front if @front < @back | |
| return @back + (@store.length - @front) |
| @front == -1 && @back == -1 | ||
| end | ||
|
|
||
| def to_s |
There was a problem hiding this comment.
👍 This works, but you could do it with just a single loop like while i != @back
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks and Queues
Thanks for doing some brain yoga. You are now submitting this assignment!
Comprehension Questions
OPTIONAL JobSimulation