Branches - Emily Ball#28
Open
eaball35 wants to merge 2 commits intoAda-C12:masterfrom
Open
Conversation
OhCloud
reviewed
Sep 20, 2019
| <meta charset="utf-8"> | ||
| <LINK REL=StyleSheet HREF="normalize.css"> | ||
| <LINK REL=StyleSheet HREF="styles.css"> | ||
| <link href="https://fonts.googleapis.com/css?family=Mansalva&display=swap" rel="stylesheet"> |
OhCloud
reviewed
Sep 20, 2019
| Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. | ||
| </blockquote> | ||
| <p> | ||
| <p class="quote-author"> |
There was a problem hiding this comment.
i really like how youre using your classes.
OhCloud
reviewed
Sep 20, 2019
| padding: 2% | ||
| } | ||
|
|
||
| section:nth-last-of-type(even) { |
OhCloud
reviewed
Sep 20, 2019
| } | ||
| blockquote:after { | ||
| content: close-quote; | ||
| } |
There was a problem hiding this comment.
this is so good. i'm going to take this into consideration next time i work with quotes.
OhCloud
reviewed
Sep 20, 2019
| justify-content: space-evenly; | ||
| } | ||
|
|
||
| .footer-sect { |
There was a problem hiding this comment.
you gave your footer alot of attention and it works beautifully.
OhCloud
reviewed
Sep 20, 2019
OhCloud
left a comment
OhCloud
left a comment
There was a problem hiding this comment.
Overall great work! Your layout is spot on and everything looks great. I did notice you didn't use ids and I liked that you didn't have to, you kept everything in classes and re-used it well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Startrly
Congratulations! You're submitting your assignment.
Comprehension Questions