Skip to content

Branches - Farah#30

Open
in-formation wants to merge 3 commits intoAda-C12:masterfrom
in-formation:master
Open

Branches - Farah#30
in-formation wants to merge 3 commits intoAda-C12:masterfrom
in-formation:master

Conversation

@in-formation
Copy link
Copy Markdown

Startrly

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
Describe a time you chose to use flexbox If everything I wanted in one row, I would use flexbox to adjust.
Describe a time you chose to use CSS Grid If things were going to be on top of each other (multiple rows) I used CSS grid.
What was a challenge you overcame in this project? Oh, just getting everything aligned with padding and margins...mostly padding.
What concept did you get the most clarity on through Startrly? I started to understand flexbox a bit more after watching a few youtube videos...but like I said earlier, it only made sense to me when everything I wanted was in a perfect single row...I definitely would like more clarify on CSS grid though.

Copy link
Copy Markdown

@morganschuler morganschuler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to add a hover section to a link to change the color. Very nice code, I loved your use of grids to make your selectors and values very clean looking! You have a wonderful future in web design ahead of you

Comment thread styles/styles.css
html {
font-family: sans-serif;
}
nav > ul {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job using ">" to target direct children!

Comment thread styles/styles.css
.quote-section > blockquote {
font-family: 'Nothing You Could Do', cursive;
}
.quote-section > p {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add the quotation marks and the dashes by doing :before with the selector, and then content: "--" as the value to add these in the CSS part!

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

""" - Same process but for the quotation marks!

Comment thread styles/styles.css
padding-top: 3%;
padding-bottom: 5%;
}
.team-members {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can make these picture round with the 'border-radius' value to mimic the wire-frame

Comment thread styles/styles.css
.sponsor-list-1 {
display:flex;
}
.sponsor-list-1 > li:nth-of-type(1){
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These selectors could maybe be condensed into one line!

Comment thread styles/styles.css
text-align:center;
justify-content: center
}
.startly-title > h1 {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe call out a button section to make that part easier to customize

Comment thread styles/styles.css
.why-section {
border-bottom: 0.75px solid black;
}
.why-section > h2 {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These selectors look really clean! Good job!

Comment thread styles/styles.css
}
nav > ul {
display:grid;
grid-template-columns: repeat(4, 1fr);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome idea making this into 4 columns!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants