Skip to content

Leaves- Natalie Tapias#35

Open
NatalieTapias wants to merge 6 commits intoAda-C12:masterfrom
NatalieTapias:master
Open

Leaves- Natalie Tapias#35
NatalieTapias wants to merge 6 commits intoAda-C12:masterfrom
NatalieTapias:master

Conversation

@NatalieTapias
Copy link
Copy Markdown

@NatalieTapias NatalieTapias commented Sep 20, 2019

Startrly

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
Describe a time you chose to use flexbox I used a flexbox for the meet the team section.
Describe a time you chose to use CSS Grid I used the CSS grid in order to keep the text beneath the bears.
What was a challenge you overcame in this project? I had a really hard time getting the nav bar spacing correctly. It took a lot of time pouring over docs with a TA to get the spacing as it is now.
What concept did you get the most clarity on through Startrly? When to use flexbox vs grid is a lot less opaque to me now and I feel more prepared to use it going forward.

Comment thread styles/style.css
justify-content: space-around;
flex-flow: row wrap;
justify-content: space-around;
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of flexbox functions!

Comment thread styles/style.css
flex-basis: auto;
justify-content: center;
align-self: space-around;
background-image: url("../images/tulip.jpeg");
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh la la! Pretty!

Comment thread styles/style.css
font-size: .5rem;
}

.block {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Way to DRY up your code by styling the two block quotes with the same CSS code.

Comment thread styles/style.css
border: 2px black;
padding: .5em;
border-style: solid;
border-color: black;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the 'black' here and the one in line 53 do the same thing?

Copy link
Copy Markdown

@jaitch jaitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Nice work!

Comment thread styles/style.css



@media screen and (max-width: 600px) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dynamic-ness of this is so cool!
Is it possible to make the elements horizontal when viewed on a large screen?

Comment thread styles/style.css
justify-content: space-evenly
}

.team ul li {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm super impressed that you were able to arrange these bears with grid without calling out/assigning each individual bear! And that they stay in formation when the screen dimensions change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants