Skip to content

Leaves - Kristina #37

Open
krismosk wants to merge 7 commits intoAda-C12:masterfrom
krismosk:master
Open

Leaves - Kristina #37
krismosk wants to merge 7 commits intoAda-C12:masterfrom
krismosk:master

Conversation

@krismosk
Copy link
Copy Markdown

Startrly

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
Describe a time you chose to use flexbox
Describe a time you chose to use CSS Grid
What was a challenge you overcame in this project?
What concept did you get the most clarity on through Startrly?

Copy link
Copy Markdown

@kelsk kelsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great code!

Comment thread index.html
<div>
<h3>Support</h3>
<ul>
<h3 class="header support">Support</h3>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your naming conventions for classes and ids make it easy to understand what the html element's purpose is, well done!

Comment thread styles/style.css
content: '"';
}

.section-blockquote-one-container p:before {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using p:before to end the quote, you could use blockquote:after. This would keep the quotes within the blockquote element, so that if you wanted to put another element between the blockquote and the p you wouldn't have to change the code for p.

Comment thread styles/style.css
text-decoration: none;
}

a:hover {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent choice to do a style change on hover on the call to action button!

Comment thread styles/style.css
grid-template-columns: repeat(auto-fill, minmax(100px,1fr));
justify-items: start;
font-family: 'Roboto', sans-serif;
grid-gap: 5rem;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome use of css grid, especially grid-gap! I'm going to refactor my own code with this. :)

Comment thread styles/style.css
font-family: 'Roboto', sans-serif;
}

#startrly {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a thought, I might call this #startrly-small or #startrly-nav-link to specify which "Startrly" on the page the css id is referring to

Comment thread styles/style.css
text-align: center;
}

.team-container {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of your flexboxes are great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants