forked from AdaGold/react-tic-tac-toe
-
Notifications
You must be signed in to change notification settings - Fork 48
space - Nora #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
thenora
wants to merge
32
commits into
Ada-C13:master
Choose a base branch
from
thenora:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
space - Nora #44
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
7ca6263
Wave 1 setup
thenora cb2e7f5
added CSS group names to components & app
thenora a5ca1da
wave 1 psuedo
thenora fad79e8
Wave 1 - YAY there's a board
thenora d78cb60
tried to refactor board and broke something...
thenora e00db64
reverted to working code
thenora 0332a6c
Merge branch 'master' of https://github.com/thenora/react-tic-tac-toe
thenora 60aae85
fixed for real this time
thenora 4163009
added notes for potential future refactor
thenora eb2b476
wave 2 psuedo code
thenora 7505a9a
typo in readme
thenora 1e0c81d
wave 3 psuedo code - check for winner or tie
thenora d8209cf
wave 4 psuedo code - reset game
thenora e9f72f6
tweaks to reset psuedo code
thenora 97a4dd4
added more questions / thoughts for ? refactors
thenora 34a7fb7
more notes added to square
thenora 95ca062
tried to add onclick only if empty to square
thenora 4e24385
added alternative onClick behavior
thenora a1d50da
It's 1 am and I have no idea what I'm doing :)
thenora ba4b0a8
YAY xo working
thenora 98ae2c9
add refactor notes before starting wave 3
thenora d138b78
started creating winner logic
thenora a607d8a
replaced nil with null
thenora c0505ae
replaced nil with null
thenora d251be6
Add todo to fix x/o changing on click
thenora 6dd2093
changed square w value to not allow change
thenora 862dd71
added more wave 4 / reset psuedocode
thenora 915acdc
added reset functionality
thenora b55209f
Added winner function but not working
thenora 036c9a0
cleaned up comments on app.js - not working
thenora 8e7c079
cleaned up comments on board
thenora 59492a7
cleaned up square component comments
thenora File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's legit. I'll go fix that.