Skip to content

Time - Kate P#2

Open
Catherina87 wants to merge 2 commits intoAda-C13:masterfrom
Catherina87:master
Open

Time - Kate P#2
Catherina87 wants to merge 2 commits intoAda-C13:masterfrom
Catherina87:master

Conversation

@Catherina87
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Kate, you hit all the learning goals here. Well done.

Comment thread lib/problems.js
Comment on lines +2 to +6
Time Complexity: O(n)
Space Complexity: O(n)
*/

const Stack = require("./stack");
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread lib/queue.js
this.rear = -1;
}

enqueue(element) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread lib/queue.js
}
}

dequeue() {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread lib/queue.js
Comment on lines 43 to 45
size() {
throw new Error("This method has not been implemented!");
return this.array.length;
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This really should be the number of elements used in the Queue.

Comment thread lib/stack.js
@@ -1,24 +1,32 @@
const LinkedList = require("./linked-list");
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants