Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
168 changes: 132 additions & 36 deletions linked_list/linked_list.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,71 +9,150 @@ def __init__(self, value, next_node = None):
# Defines the singly linked list
class LinkedList:
def __init__(self):
self.head = None # keep the head private. Not accessible outside this class
self.head = None # keep the head private. Not accessible outside this class

# returns the value in the first node
# returns None if the list is empty
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(1)
# Space Complexity: O(1)
def get_first(self):
Comment on lines +16 to 18
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pass

return None if self.head is None else self.head.value

# method to add a new node with the specific data value in the linked list
# insert the new node at the beginning of the linked list
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(1)
# Space Complexity: O(1)
def add_first(self, value):
Comment on lines +23 to 25
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pass
new_node = Node(value, self.head)

self.head = new_node

return self.head

# method to find if the linked list contains a node with specified value
# returns true if found, false otherwise
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(n)
# Space Complexity: O(1)
def search(self, value):
Comment on lines +34 to 36
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pass
current_node = self.head

while current_node:
if current_node.value == value:
return True
current_node = current_node.next

return False

# method that returns the length of the singly linked list
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(n)
# Space Complexity: O(1)
def length(self):
Comment on lines +47 to 49
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pass
current_node = self.head
length = 0

while current_node:
length += 1
current_node = current_node.next

return length

# method that returns the value at a given index in the linked list
# index count starts at 0
# returns None if there are fewer nodes in the linked list than the index value
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(n)
# Space Complexity: O(1)
def get_at_index(self, index):
Comment on lines +62 to 64
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pass
if self.head is None:
return None

current_node = self.head
i = 0
while i < index and current_node:
current_node = current_node.next
i+=1

return current_node.value

# method that returns the value of the last node in the linked list
# returns None if the linked list is empty
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(n)
# Space Complexity: O(1)
def get_last(self):
Comment on lines +78 to 80
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pass
if self.head is None:
return None

current = self.head

while current:
if current.next is None:
return current.value
else:
current = current.next

# method that inserts a given value as a new last node in the linked list
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(n)
# Space Complexity: O(1)
def add_last(self, value):
Comment on lines +93 to 95
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pass
new_node = Node(value)

if self.head is None:
self.head = new_node
return

last_node = self.head

while last_node.next:
last_node = last_node.next

last_node.next = new_node

# method to return the max value in the linked list
# returns the data value and not the node
# Time Complexity: O(n)
# Space Complexity: O(1)
def find_max(self):
Comment on lines +111 to 113
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pass
if self.head is None:
return None

current = self.head
max = self.head.value

while current.next:
if current.next.value > max:
max = current.next.value
current = current.next
else:
current = current.next

return max

# method to delete the first node found with specified value
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(n)
# Space Complexity: O(1)
def delete(self, value):
Comment on lines +130 to 132
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ See below for a subtle error

pass
if self.head is None:
return None

current = self.head
if current.value == value:
self.head = current.next
return

while current:
if current.value == value:
current = current.next
return
Comment on lines +142 to +144
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look right


prev = current
current = current.next
if current.value == value:
prev.next = current.next
return
Comment on lines +146 to +150
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right, but I think the prior if statement could cause an occasional subtle bug.



# method to print all the values in the linked list
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(n)
# Space Complexity: O(n)
def visit(self):
Comment on lines +154 to 156
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

helper_list = []
current = self.head
Expand All @@ -86,17 +165,34 @@ def visit(self):

# method to reverse the singly linked list
# note: the nodes should be moved and not just the values in the nodes
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(n)
# Space Complexity: O(1)
def reverse(self):
Comment on lines +168 to 170
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pass

prev = None
current = self.head
next = None

while current:
next = current.next
current.next = prev
prev = current
current = next
self.head = prev


## Advanced/ Exercises
# returns the value at the middle element in the singly linked list
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(n)
# Space Complexity: O(1)
def find_middle_value(self):
Comment on lines +185 to 187
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice!

pass
slow = self.head
fast = self.head

while fast and fast.next:
slow = slow.next
fast = fast.next.next

return slow.value

# find the nth node from the end and return its value
# assume indexing starts at 0 while counting to n
Expand Down
4 changes: 2 additions & 2 deletions tests/linked_list_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ def test_reverse_will_reverse_five_element_list(list):
for i in range(0, 5):
assert list.get_at_index(i) == i

@pytest.mark.skip(reason="Going Further methods")
# @pytest.mark.skip(reason="Going Further methods")
def test_find_middle_value_returns_middle_element_of_five_element_list(list):
list.add_first(10)
list.add_first(30)
Expand All @@ -206,7 +206,7 @@ def test_find_middle_value_returns_middle_element_of_five_element_list(list):
list.add_first(20)
assert list.find_middle_value() == 50

@pytest.mark.skip(reason="Going Further methods")
# @pytest.mark.skip(reason="Going Further methods")
def test_find_middle_value_returns_element_at_index_two_of_six_element_list(list):
list.add_first(10)
list.add_first(30)
Expand Down