Scissors - Mariela Cruz#41
Open
marielaxcruz wants to merge 2 commits intoAda-C15:masterfrom
Open
Conversation
CheezItMan
reviewed
Oct 14, 2021
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work Mariela, you hit the learning goals here. Well done.
I left some minor comments, but this is a solid submission. Let me know what questions you have.
Comment on lines
+18
to
20
| # Time Complexity: O(1) | ||
| # Space Complexity: O(n) | ||
| def get_first(self): |
Comment on lines
+28
to
30
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
| def add_first(self, value): |
Comment on lines
+31
to
+41
| current = self.head | ||
| if self.head == None: | ||
| self.head = Node(value) | ||
| self.tail = self.head | ||
| self.size += 1 | ||
| else: | ||
| new_node = Node(value) | ||
| new_node.next = current | ||
| current.previous = new_node | ||
| self.head = new_node | ||
| self.size += 1 |
There was a problem hiding this comment.
Could be more compact
Suggested change
| current = self.head | |
| if self.head == None: | |
| self.head = Node(value) | |
| self.tail = self.head | |
| self.size += 1 | |
| else: | |
| new_node = Node(value) | |
| new_node.next = current | |
| current.previous = new_node | |
| self.head = new_node | |
| self.size += 1 | |
| self.head = Node(value, self.head) | |
| self.size += 1 | |
| if self.tail is None: | |
| self.tail = self.head |
Comment on lines
+45
to
47
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def search(self, value): |
Comment on lines
+56
to
58
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
| def length(self): |
Comment on lines
+114
to
+117
| if self.head == None: | ||
| self.head = new_node | ||
| self.tail = self.head | ||
| self.size += 1 |
There was a problem hiding this comment.
In this scenario, you could also call self.add_first
| # testing? | ||
| # method to return the max value in the linked list | ||
| # returns the data value and not the node | ||
| def find_max(self): |
Comment on lines
+143
to
145
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def delete(self, value): |
Comment on lines
+178
to
180
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def visit(self): |
Comment on lines
+192
to
194
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def reverse(self): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.