Alison McGinley C15#42
Open
elisonmcginley wants to merge 1 commit intoAda-C15:masterfrom
Open
Conversation
CheezItMan
reviewed
Oct 20, 2021
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Great work Alison, you hit the learning goals here. This was almost perfect. Well done.
Comment on lines
+16
to
18
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
| def get_first(self): |
Comment on lines
+24
to
26
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
| def add_first(self, value): |
Comment on lines
+27
to
+30
| if not self.head: | ||
| self.head = Node(value, self.head) | ||
| else: | ||
| self.head = Node(value, self.head) |
There was a problem hiding this comment.
Could be compacted
Suggested change
| if not self.head: | |
| self.head = Node(value, self.head) | |
| else: | |
| self.head = Node(value, self.head) | |
| self.head = Node(value, self.head) |
Comment on lines
+34
to
36
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def search(self, value): |
Comment on lines
+47
to
49
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def length(self): |
Comment on lines
+126
to
128
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def delete(self, value): |
Comment on lines
+146
to
148
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def visit(self): |
Comment on lines
+160
to
162
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def reverse(self): |
Comment on lines
+181
to
183
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def find_middle_value(self): |
Comment on lines
+190
to
192
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def find_nth_from_end(self, n): |
There was a problem hiding this comment.
👍 Nice use of prior methods and arithmetic!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.