Rock - Juliana #43
Open
julianadecarvalho wants to merge 1 commit intoAda-C15:masterfrom
Open
Conversation
CheezItMan
reviewed
Oct 20, 2021
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Awesome work Juliana! You hit the learning goals here. Well done. I left some comments, mostly in terms of time/space complexity. Let me know what questions you have on the feedback..
Solid submission.
Comment on lines
+16
to
18
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
| def get_first(self): |
Comment on lines
+25
to
27
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
| def add_first(self, value): |
Comment on lines
+32
to
34
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def search(self, value): |
Comment on lines
+44
to
46
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def length(self): |
Comment on lines
+58
to
60
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def get_at_index(self, index): |
Comment on lines
+84
to
86
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def add_last(self, value): |
Comment on lines
+101
to
103
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def find_max(self): |
There was a problem hiding this comment.
👍 However the space complexity is O(1) because you're not creating new nodes.
Comment on lines
+117
to
119
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def delete(self, value): |
Comment on lines
+137
to
139
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def visit(self): |
Comment on lines
+151
to
153
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def reverse(self): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finally done, woot!