linked list exercise(Sumitra)#44
Open
sumitrac wants to merge 1 commit intoAda-C15:masterfrom
Open
Conversation
CheezItMan
reviewed
Oct 20, 2021
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work Sumitra, you hit the learning goals here. I had a few comments, mostly on time/space complexity. Let me know if you have questions on my feedback.
Comment on lines
+15
to
17
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def get_first(self): |
Comment on lines
+26
to
28
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def add_first(self, value): |
There was a problem hiding this comment.
👍 However this is O(1) for both time/space complexity.
Comment on lines
+34
to
36
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def search(self, value): |
Comment on lines
+45
to
47
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def length(self): |
Comment on lines
+58
to
60
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def get_at_index(self, index): |
Comment on lines
+86
to
88
| # Time Complexity: O(1) | ||
| # Space Complexity: O(n) | ||
| def add_last(self, value): |
|
|
||
| # method to return the max value in the linked list | ||
| # returns the data value and not the node | ||
| def find_max(self): |
Comment on lines
+113
to
115
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def delete(self, value): |
Comment on lines
+130
to
132
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def visit(self): |
Comment on lines
+144
to
146
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def reverse(self): |
There was a problem hiding this comment.
👍 However the space complexity is O(1) because you're not creating new nodes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.