Al Leonard - Linked List#48
Open
Alli-Oops wants to merge 2 commits intoAda-C15:masterfrom
Open
Conversation
CheezItMan
reviewed
Nov 22, 2021
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Al, overall nice work you hit the learning goals here, except you never tried working out the time/space complexity. I do suggest you try that as it's good practice.
Otherwise I only made some suggestions for drying up the code a bit. Let me know if you have questions.
Comment on lines
+40
to
+48
| if current == None: | ||
| return False | ||
| while current: | ||
| if current.value == value: | ||
| return True | ||
| current = current.next | ||
| notTrue = True | ||
| if notTrue == True: | ||
| return False |
There was a problem hiding this comment.
Can be simplified
Suggested change
| if current == None: | |
| return False | |
| while current: | |
| if current.value == value: | |
| return True | |
| current = current.next | |
| notTrue = True | |
| if notTrue == True: | |
| return False | |
| if current == None: | |
| return False | |
| while current: | |
| if current.value == value: | |
| return True | |
| current = current.next | |
| return False |
Comment on lines
+65
to
+66
| if node_count: | ||
| return node_count |
There was a problem hiding this comment.
Suggested change
| if node_count: | |
| return node_count | |
| return node_count | |
| def __init__(self): | ||
| self.head = None # keep the head private. Not accessible outside this class | ||
| self.head = None # keep the head private. Not accessible outside this class | ||
| self.tail = None # keep track of the tail |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for looking at my Linked List answers!