Abigail C - Rock#55
Open
ChaAbby wants to merge 1 commit intoAda-C15:masterfrom
Open
Conversation
CheezItMan
reviewed
Jan 14, 2022
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work Abigail, you hit the learning goals here. I left some minor feedback for you, but this was well done.
Comment on lines
+22
to
24
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
| def get_first(self): |
Comment on lines
+32
to
34
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
| def add_first(self, value): |
Comment on lines
+35
to
+36
| new_node = Node(value, next_node=self.head) | ||
| self.head = new_node |
There was a problem hiding this comment.
Can be rewritten
Suggested change
| new_node = Node(value, next_node=self.head) | |
| self.head = new_node | |
| self.head = Node(value, next_node=self.head) |
Comment on lines
+40
to
43
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
|
|
||
| def search(self, value): |
Comment on lines
+53
to
56
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
|
|
||
| def length(self): |
Comment on lines
+124
to
+126
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def delete(self, val): |
Comment on lines
+144
to
146
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def visit(self): |
Comment on lines
+158
to
160
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def reverse(self): |
Comment on lines
+174
to
176
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def find_middle_value(self): |
There was a problem hiding this comment.
👍 This works, but you could either:
- use the
lengthmethod - or have a fast and slow node reference where the fast move 2 nodes with each iteration and the slow moves one. Then when the fast reaches the end, the slow is referring to the middle node.
| # # assume indexing starts at 0 while counting to n | ||
| # # Time Complexity: O(n) | ||
| # # Space Complexity: O(1) | ||
| def find_nth_from_end(self, n): |
There was a problem hiding this comment.
👍 this works with similar feedback to find middle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.