Scissors - Ivana#57
Open
i-vs wants to merge 1 commit intoAda-C15:masterfrom
Open
Conversation
CheezItMan
reviewed
Jan 18, 2022
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work Ivana, this all works. Take a look at my minor feedback, but this is quite well done.
Comment on lines
+19
to
21
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
| def get_first(self): |
Comment on lines
+28
to
30
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
| def add_first(self, value): |
Comment on lines
+31
to
+33
| node = Node(value, self.head) | ||
| self.head = node | ||
| self.size += 1 |
There was a problem hiding this comment.
Suggested change
| node = Node(value, self.head) | |
| self.head = node | |
| self.size += 1 | |
| self.head = Node(value, self.head) |
Comment on lines
+37
to
39
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) constant space w/ no additional space in memory | ||
| def search(self, value): |
Comment on lines
+40
to
+41
| if self.head is None: | ||
| return False |
There was a problem hiding this comment.
Not needed
Suggested change
| if self.head is None: | |
| return False | |
| if self.head is None: | |
| return False |
Comment on lines
+153
to
155
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def visit(self): |
Comment on lines
+167
to
169
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def reverse(self): |
Comment on lines
+185
to
188
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
|
|
||
| def find_middle_value(self): |
There was a problem hiding this comment.
👍 Another great reuse of get_at_index
Comment on lines
+205
to
208
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
|
|
||
| def find_nth_from_end(self, n): |
Comment on lines
+225
to
227
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def has_cycle(self): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.