Paper- Andrea Palacios#58
Open
dre-create wants to merge 1 commit intoAda-C15:masterfrom
Open
Conversation
CheezItMan
reviewed
Jan 24, 2022
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work Andrea, you hit the learning goals here. Well done.
Comment on lines
+16
to
18
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
| def get_first(self): |
Comment on lines
+34
to
36
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def search(self, value): |
Comment on lines
+66
to
68
| # Time Complexity: O(n) | ||
| # Space Complexity:O(1) | ||
| def get_at_index(self, index): |
Comment on lines
+84
to
86
| # Time Complexity: O(n) | ||
| # Space Complexity: 0(1) | ||
| def get_last(self): |
| if not self.head: | ||
| return | ||
| current = self.head | ||
| while current: |
There was a problem hiding this comment.
You could also do a while current.next: and then you don't need the following if statement.
Comment on lines
+144
to
146
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def visit(self): |
Comment on lines
+158
to
160
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def reverse(self): |
Comment on lines
+172
to
174
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def find_middle_value(self): |
Comment on lines
+180
to
182
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def find_nth_from_end(self, n): |
There was a problem hiding this comment.
👍 Good re-use of methods and arithmetic.
Comment on lines
+189
to
191
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def has_cycle(self): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.