Scissors - Araceli #61
Open
aracelim1234 wants to merge 1 commit intoAda-C15:masterfrom
Open
Conversation
CheezItMan
reviewed
Jan 24, 2022
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work Araceli, you hit the learning goals here. I had some minor feedback. Let me know if you have any questions.
Comment on lines
+19
to
21
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
| def get_first(self): |
Comment on lines
+29
to
31
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def add_first(self, value): |
Comment on lines
+32
to
+36
| node = Node(value) | ||
| node.next = self.head | ||
| self.head = node | ||
|
|
||
| return node |
There was a problem hiding this comment.
Suggested change
| node = Node(value) | |
| node.next = self.head | |
| self.head = node | |
| return node | |
| self.head = Node(value, self.head) | |
| return self.head |
Comment on lines
40
to
42
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def search(self, value): |
Comment on lines
52
to
54
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def length(self): |
Comment on lines
+89
to
91
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def get_last(self): |
Comment on lines
+103
to
105
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def add_last(self, value): |
Comment on lines
+121
to
123
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def find_max(self): |
Comment on lines
+141
to
143
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def delete(self, value): |
Comment on lines
+173
to
175
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def reverse(self): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.