Pine - Tori D.#63
Open
VictoriaDuke wants to merge 2 commits intoAda-C16:mainfrom
Open
Conversation
jbieniosek
reviewed
Jan 7, 2022
jbieniosek
left a comment
jbieniosek
left a comment
There was a problem hiding this comment.
Great work on Wave 1 Tori! There was no formal LP for this project, but with wave 1 working and wave 2 started and considering the surrounding circumstances I am going to mark this as yellow. However, I recommend coming back to this project at the beginning of Capstone and working through the click callback code as a way to prep for Capstone.
| // of square components | ||
|
|
||
| } | ||
| const arr1d = [].concat.apply([], squares); |
Comment on lines
+12
to
+19
| return arr1d.map((square) => ( | ||
| <Square | ||
| key={square.id} | ||
| value={square.value} | ||
| onClickCallback={onClickCallback} | ||
| ></Square> | ||
| )); | ||
| }; |
| // You will need to create a method to change the square | ||
| // When it is clicked on. | ||
| // Then pass it into the squares as a callback | ||
| const newSquares = squares.map((square) => { |
There was a problem hiding this comment.
This section of code isn't working because squares is a 2D array. In this case there may be a way to get map to work (perhaps by nesting) but I recommend a nested for loop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.