Adah's #72
Open
Aghaile wants to merge 6 commits intoAda-C16:mainfrom
Open
Conversation
tgoslee
reviewed
Jan 4, 2022
Comment on lines
+35
to
+36
| // let currentPlayer = player_1; | ||
| // let winner = null; |
tgoslee
reviewed
Jan 4, 2022
| let resetBoard = generateSquares(); | ||
| setCurrentPlayer(player1); | ||
| setWinner(null); | ||
| setSquares(resetBoard); |
There was a problem hiding this comment.
you can just say setSquares(generateSquares())
tgoslee
reviewed
Jan 4, 2022
| }; | ||
|
|
||
| const onClickCallback = (id) => { | ||
| console.log('onclick', id); |
tgoslee
reviewed
Jan 4, 2022
| </header> | ||
| <main> | ||
| <Board squares={squares} /> | ||
| <Board onClickCallback={boardCallback} squares={squares} /> |
There was a problem hiding this comment.
here you can just reference the function in the curly braces instead of making a separate variable. So onClickCallback={onClickCallback}
|
Good Job Adah! I just added a few comments on what you can refactor. Also, when pushing your final code do a final walk-through of code to remove console logs and commented code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.