Zoisite- Halimat-A

[Havana82]

No description provided.

[yangashley]

notice that the creation of this dictionary is also on lines 24-27. We can create an instance method in the planet class called to_dict that handles turning a planet into a dictionary that represents the planet.

Then in each of your routes, you could make the code more concise by writing:

planet = validate_planet(planet_id)
return planet.to_dict()

Here's how we handled this refactor in Flasky with the Cat class: https://github.com/Ada-C19/flasky/blob/zoisite/app/routes.py#L10-L16

[yangashley]

nitpick: white spacing around the equal sign should be the same on both sides:
planets_bp = Blueprint('planets', __name__,url_prefix='/planets')

[yangashley]

Tthe decorator should come right before the function definition with no white space: https://www.flake8rules.com/rules/E304.html#:~:text=There%20should%20be%20no%20blank,the%20function%20it%20is%20decorating.

[yangashley]

Nice job on Waves 1 & 2! It looks like you've got a handle on creating a blueprint, registering it with your Flask app and writing routes. With the suggested refactor, you'll be able to pull some logic out of your routes so that they can be even more concise.

[yangashley]

Nice job finishing up Solar System Part 2 independently 🥳 I left some comments about consistently using white spaces in your code.

I also left some comments about how to make your tests more robust, how you can refactor the code to make it a little more concise, and places that you'll need to add error handling so that your API will properly handle bad data from the client.

Let me know if you have any questions!

[yangashley]

Notice that line 14 and 18 are the same. Since this line of code needs to execute for both conditions, you can bring it outside the if/else block.

[yangashley]

Since you don't have any conditional logic when you create a dictionary and add key value pairs to it, you can directly return a dictionary literal like:

        return {
            "id": self.id,
            "name": self.name,
            "description": self.description,
            "form": self.form
        }

[yangashley]

Instead of hardcoding Planet on line 19, we should use the cls variable that a class method can access.

Since you don't have any conditional logic when you create an instance of the object, you can directly return the object like this without needing to create the variable new_planet:

return cls(
            name = data_dict["name"],
            description = data_dict["description"],
            radius = data_dict["form"]
        )

[yangashley]

Now that you've refactored Planet into it's own file, you can delete these comments to keep your project concise

[yangashley]

nitpick: there should be a space after the comma (cls, model_id)

[yangashley]

If you return planets from saved_planets (see my comment in conftest.py) then you could check that the actual planet queried from the database in your fixture are the same as what's returned from this GET request in your test.

That could look like:

mercury = saved_planets[0]
assert response_body["id"] == mercury.id
assert response_body[name"] == mercury.name
assert response_body["description"] == mercury.description
assert response_body["form"] == mercury.form

[yangashley]

Since this is a GET request for all planets, we should also have an assertion to check that response_body[1] is equal to something.

If saved_planets returned a list of planets, then you could make this test even more robust by checking what is inside saved_planets against the response body (see my comment in test_get_one_planet_with_test_data)

[yangashley]

A way to make this test more robust would to check the actual_planet against the values in PLANET_DICT, instead of string literals. That would look like:

assert actual_planet.name == EXPECTED_PLANET["name"] 
assert actual_planet.description == EXPECTED_PLANET["description"]
assert actual_planet.form == EXPECTED_PLANET["form"]

[yangashley]

👍

[yangashley]

nitpick: the spacing here is inconsistent. we need a space after the comma after db.Integer and there should be no spaces before and after equal sign for the last 2 arguments. That would look like:

id = db.Column(db.Integer, primary_key=True, autoincrement=True)