feat(ogar-render-askama): W2/W3 fieldview — the addressed desktop surface#207
Merged
Merged
Conversation
…face
Add ogar-render-askama::field_view — the render half of the A2UI screen-
addressing charter (docs/A2UI-SCREEN-ADDRESSING-PROPOSAL.md, C1.2): a
WideFieldMask-projected ClassView instance renders as an ADDRESSED surface
rather than a rasterized bitmap.
- render_field_view(class_id, concept, key_hex, title, fields, actions) +
templates/dispatch/field_view.askama.
- Every field carries data-field-pos = its WideFieldMask position (its layout
address); every action carries data-action-ordinal = its ActionDef address
(trap T2 — no inline handler is representable). The node key addresses the
whole surface (data-key).
- from_value_rows / from_render_rows: direct ClassView-projection bridges
(lance_graph_contract::class_view::{ValueRow,RenderRow} -> FieldView).
- escape="html", no |safe hatch: the XSS class the list/detail kits fixed
under codex P1 (#83/#84) cannot arise on a fieldview.
5 new tests (addressed render incl. a wide position >= 64, XSS regression,
empty-action nav omit, both projection bridges); 61 crate tests green,
clippy clean. Consumed by the a2ui-rs W2 a2ui-server tier.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UZmHUePVbVXjHJWoBmABiZ
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_112b6fc4-2e32-448a-a4c6-11e49b5a5a90) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
ogar-render-askama::field_view— the render half of the A2UIscreen-addressing charter (
docs/A2UI-SCREEN-ADDRESSING-PROPOSAL.md, C1.2):a
WideFieldMask-projectedClassViewinstance renders as an addressedsurface rather than a rasterized bitmap. Don't push pixels — address the
screen.
Surface
render_field_view(class_id, concept, key_hex, title, fields, actions)+templates/dispatch/field_view.askama.data-field-pos= itsWideFieldMaskposition (itslayout address); every action carries
data-action-ordinal= itsActionDefaddress (trap T2 — no inline handler is representable). Thenode key addresses the whole surface (
data-key).from_value_rows/from_render_rows— direct ClassView-projection bridges(
lance_graph_contract::class_view::{ValueRow, RenderRow}→FieldView).escape="html", no|safehatch: the XSS class the list/detail kits hadto fix under codex P1 (feat(ogar-render-askama): T2 — HtmlListView (Redmine spine on ClassView substrate) #83/feat(ogar-render-askama): T3 — HtmlDetailView (Redmine show.html.erb on ClassView) #84) cannot arise on a fieldview.
Tests
5 new tests (addressed render incl. a wide position ≥ 64, XSS regression,
empty-action nav omit, both projection bridges). 61 crate tests green,
clippy clean.
Consumer
Consumed by the a2ui-rs W2
a2ui-servertier (RBAC-projectWideFieldMask ∩ role→NodeDeltadown + this fieldview render;ActionInvokeup by ordinal;ogar-encryptionsealed transport). Ledger:docs/DISCOVERY-MAP.mdD-A2UI-SCREEN-ADDRESSING(status appended in this PR).🤖 Generated with Claude Code
https://claude.ai/code/session_01UZmHUePVbVXjHJWoBmABiZ
Generated by Claude Code