knowledge: D-SF-BASIN-1 scope precision — facet-L2 multimap vs shipped graph memberof

[AdaWorldAPI]

Summary

Follow-up to #682 addressing a CodeRabbit precision comment. The D-SF-BASIN-1 wording "one NodeGuid is memberof both basins" could be read as a shipped production relation; it isn't. Doc-only, no result change (D-SF-BASIN-1 stays GREEN).

The fix

Verified against crates/lance-graph/src/graph/mailbox_scan.rs: the shipped graph memberof is HHTL-tier many-to-one (Option<BasinOf> → Local/Route/Top, a single parent basin). The probe's "many-basins-one-node" is a different relation — the facet L2 memberof:members rails (up to 6 basins per node), which the probe holds in an in-memory HashMap<NodeGuid, HashSet<basin>> because the facet lane isn't a persisted ValueTenant yet.

The doc now separates the two notions explicitly in both the table row and the D-SF-BASIN-1 deliverable:

1. facet L2 rails — the multi-basin membership the probe exercises (in-memory today, persistence future);
2. shipped graph memberof — HHTL-tier single-parent, a distinct relation.

So the many-basins-one-node relation rides the facet L2 rails, NOT the graph HHTL memberof. Encoding proven; persistence future.

Testing

Doc-only.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Awg6TXocHcwTtc6eGsHcdD

---

Generated by Claude Code

[coderabbitai]

Warning

Review limit reached

@AdaWorldAPI, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 50 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9f0f4081-0ea5-4684-ab1b-c849e4db02cb

📥 Commits

Reviewing files that changed from the base of the PR and between 21fe072 and b575a57.

📒 Files selected for processing (1)

• .claude/knowledge/stockfish-nnue-as-perturbation-cascade.md

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[cursor]

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_bebcc725-095d-467e-896e-73372fe07d83)