docs(contract)+knowledge+agents: de-brand sequencing primitives; bank the compilation-vs-runtime + assembler-vs-storage rulings#693
Merged
Conversation
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_ac180be4-2d61-4669-8e19-e6d77094ff1f) |
📝 WalkthroughWalkthroughThe PR adds compile-time and substrate-boundary guidance, records related governance findings, and clarifies contract sequencing documentation. It also reformats a 24-bit assertion without changing its behavior. ChangesDocumentation and contract cleanup
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…mpute_dag/execute_defaults doc-comments (5+3 council R5)
A 5+3 council flagged that the ZERO-DEP contract's recipe-sequencing
primitives were branded "the ActionDef value executor" and carried one
consumer's provenance ("the medcare transpile arc's lane-3a increment", "the
sono Recal_* family", "RecipeCentroid::Default harvest") in their doc-comments
— which every consumer of the contract inherits. They are generic sequencing
primitives, NOT an ActionDef-body interpreter (that is OGAR's
ACTIONDEF-VALUE-DISPATCH-PROPOSAL.md concern).
- execute_compute_dag / execute_defaults doc-comments reworded to describe the
primitive generically (topological-order / fire-if-absent sequencing over
ComputeEdge / positions) + a scope-note drawing the ActionDef-interpreter
boundary explicitly. Code unchanged; 48 class_view tests green.
- ClassView::default_targets + test section comments de-branded likewise.
- E-LAYER-CONFUSION-OGAR-VS-SPINE-1 (EPIPHANIES) + AGENT_LOG entry record the
council run and the load-bearing result: #690's execute_defaults IS correctly
placed (OGAR consumes lance_graph_contract::ClassView) — NOT reverted.
- Filed #692 for the highest residual: contract::action re-declares OGAR IR
names with no shape-parity fuse.
Incidental: cargo fmt fixed a pre-existing fmt-dirty legacy_outliers.rs
(same as the thinking_styles/style_family reflow in #690).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
AdaWorldAPI
force-pushed
the
claude/council-contract-doclabel-cleanup
branch
from
1219b84 to
b4ce015
Compare
…ine (operator rulings, 2026-07-14) Two knowledge files and two guard agents banking the two layer distinctions the operator ruled after the #691/#208 failure chain: - knowledge/compilation-vs-runtime-substrate.md — contracts compile types; ruff+OGAR codegen emits Rust INTO consumer repos; cargo (laptop/CI/Railway pulling GitHub) builds them against ogar-vocab/lance-graph-contract as plain type deps. The SoA / temporal.rs / NARS / RBAC / mailbox write-on-behalf machinery is the running engine's INTERNAL mechanics — it never gates a build or a typed-value construction. Canonical negative image: the door-knocking compiler ("may I compile on behalf of the SoA using RBAC..."). 30-second checklist. - knowledge/assembler-vs-storage-substrate.md — OGAR is the V3 assembler substrate (IR, minting, codegen); lance-graph is the spine (zero-dep type contracts + query/planner); Lance persistence is calcification, never an ingest API. Ownership quick-map + the observed failure signatures (wrong-repo filing, "ingest" vocabulary, "V3 substrate = lance-graph", compiler-on-disk). - agents/layer-boundary-warden.md — pre-flight gate; verdicts COMPILE-TIME-CLEAN / RUNTIME-CLEAN / MIXED-SPLIT-IT / DOOR-KNOCKER / WRONG-SHELF; fires before cross-repo issues and seam docs. - agents/codegen-flow-cartographer.md — carries the harvest→mint→codegen→ consumer-repo→cargo pipeline map; answers placement/phase questions with receipts while a design is being written. CLAUDE.md knowledge list registers both docs. Companion GitHub state: OGAR #208 closed as hallucinated + repurposed to state the two distinctions; OGAR #209 is the from-scratch rewrite of the Klickwege seam at the correct (compile-time) layer. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_447f19a5-7c33-43a8-b8b7-ddd38a57958c) |
AdaWorldAPI
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.claude/agents/codegen-flow-cartographer.md (1)
30-30: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueSpecify a language for the fenced code block.
To prevent markdown linting warnings, specify a language identifier (e.g.,
text) for this fenced code block.♻️ Proposed fix
-``` +```text🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.claude/agents/codegen-flow-cartographer.md at line 30, Update the fenced code block in the codegen-flow-cartographer documentation to include an explicit language identifier, such as text, immediately after the opening fence; leave the block’s contents unchanged.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.claude/agents/codegen-flow-cartographer.md:
- Line 30: Update the fenced code block in the codegen-flow-cartographer
documentation to include an explicit language identifier, such as text,
immediately after the opening fence; leave the block’s contents unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: e34ac3f0-db78-460f-86a4-eb6c9a7c29be
📒 Files selected for processing (9)
.claude/agents/codegen-flow-cartographer.md.claude/agents/layer-boundary-warden.md.claude/board/AGENT_LOG.md.claude/board/EPIPHANIES.md.claude/knowledge/assembler-vs-storage-substrate.md.claude/knowledge/compilation-vs-runtime-substrate.mdCLAUDE.mdcrates/lance-graph-contract/src/class_view.rscrates/lance-graph-contract/src/legacy_outliers.rs
🚧 Files skipped from review as they are similar to previous changes (1)
- crates/lance-graph-contract/src/legacy_outliers.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two commits, one correction arc
Commit 1 — strip consumer-provenance label-bleed (5+3 council R5)
The zero-dep contract's
execute_compute_dag/execute_defaultsdoc-comments branded them "the ActionDef value executor" and baked one consumer's provenance into them ("the medcare transpile arc's lane-3a increment", "the sonoRecal_*family"). Every consumer oflance-graph-contractinherits that mislabel. They are generic sequencing primitives — reworded generically + an explicit scope-note ("NOT anActionDef-body interpreter; takes noActionDef, reads nokausal/EnterEffect" — that concern is OGAR'sACTIONDEF-VALUE-DISPATCH-PROPOSAL.md). Code untouched; 48 class_view tests green;E-LAYER-CONFUSION-OGAR-VS-SPINE-1+ AGENT_LOG record the council run. Load-bearing council result: #690's placement is correct — OGAR'sogar-class-viewconsumeslance_graph_contract::ClassView; nothing reverted. Filed #692 (contract::actionshape-parity-fuse gap).Commit 2 — bank the two operator rulings as knowledge + guard agents
The failure chain (#691 wrong-repo → OGAR #208 hallucinated three times) came from two conflations the operator ruled on. Banked so no session re-derives them the hard way:
knowledge/compilation-vs-runtime-substrate.md— contracts compile types; ruff+OGAR codegen emits Rust into consumer repos; cargo (laptop/CI/Railway) builds them againstogar-vocab/lance-graph-contractas plain type deps. SoA /temporal.rs/ NARS / RBAC / mailbox write-on-behalf = the running engine's internal mechanics — never a gate on a build or a typed-value construction (the door-knocking-compiler test). 30-second checklist.knowledge/assembler-vs-storage-substrate.md— OGAR = the V3 assembler substrate (IR/mint/codegen); lance-graph = spine (contracts + query); Lance persistence = calcification, never an ingest API. Ownership quick-map + the observed failure signatures.agents/layer-boundary-warden.md— pre-flight gate (verdicts: COMPILE-TIME-CLEAN / RUNTIME-CLEAN / MIXED-SPLIT-IT / DOOR-KNOCKER / WRONG-SHELF), fires before cross-repo issues and seam docs.agents/codegen-flow-cartographer.md— carries the harvest→mint→codegen→consumer-repo→cargo pipeline map; answers placement/phase questions with receipts while a design is being written.Companion GitHub state (same arc)
OGAR #208 closed as HALLUCINATED + repurposed: its body now states the two distinctions verbatim-spirit. OGAR #209 is the from-scratch rewrite of the Klickwege seam at the correct layer — a compile-time lowering fn + golden test, cargo-only, zero ceremony. MedCare-rs #211 (E-MEDCARE-30) and the a2ui-rs seams-doc retraction complete the set.
🤖 Generated with Claude Code
Summary by CodeRabbit