Skip to content

Fix cockpit-server build: import ThinkingStyle from its canonical module#105

Merged
AdaWorldAPI merged 1 commit into
mainfrom
claude/fix-notebook-query-thinkingstyle
Jul 13, 2026
Merged

Fix cockpit-server build: import ThinkingStyle from its canonical module#105
AdaWorldAPI merged 1 commit into
mainfrom
claude/fix-notebook-query-thinkingstyle

Conversation

@AdaWorldAPI

@AdaWorldAPI AdaWorldAPI commented Jul 13, 2026

Copy link
Copy Markdown
Owner

main is currently broken — the cockpit-server release build fails:

error[E0432]: unresolved import `lance_graph_planner::api::ThinkingStyle`

Cause: cross-repo drift. lance-graph added an api re-export of ThinkingStyle after the lance-graph rev this repo pins, so lance_graph_planner::api::ThinkingStyle no longer resolves against the pinned dependency. (This fix was pushed to #104's branch after it merged green, so it stranded — hence a fresh PR off main.)

Fix: import ThinkingStyle from its canonical module lance_graph_planner::thinking::style — where the enum is actually defined (pub mod thinkingpub mod style), public in every lance-graph version. The compiler itself suggests this path. Planner/PlanResult still come from api. Same type, no behavior change.

Two planner-gated call sites in crates/stubs/notebook-query (lib.rs, diagnostics.rs).

Verification

  • cargo check -p notebook-query --features plannerFinished clean (local, 6m18s).
  • Module path confirmed public end-to-end (pub mod thinkingpub mod style).

🤖 Generated with Claude Code


Generated by Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Improved compatibility for planner-related notebook functionality by correcting internal type resolution.
    • Planner execution and diagnostic behavior remain unchanged.

…eploy build)

The cockpit-server release build (Railway) failed:
  error[E0432]: unresolved import `lance_graph_planner::api::ThinkingStyle`

lance-graph moved `ThinkingStyle` behind an `api` re-export that POSTDATES the
lance-graph rev this repo pins, so importing it from `lance_graph_planner::api`
no longer resolves against the pinned dependency. The enum itself has always
lived at `lance_graph_planner::thinking::style::ThinkingStyle` (pub mod thinking
→ pub mod style), which resolves against every lance-graph version — the
compiler's own suggestion.

Import ThinkingStyle from that canonical path in the two `planner`-gated call
sites (diagnostics.rs, lib.rs); Planner/PlanResult still come from `api`. No
behaviour change — same type, robust import path. Unblocks the cockpit-server
deploy (and any q2 build against the pinned lance-graph).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012jEwwaT5JZ5x8qWvcnaMYC
@cursor

cursor Bot commented Jul 13, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_ae87fab7-8c22-49df-9abe-ac87d2badc37)

@AdaWorldAPI AdaWorldAPI merged commit ccbfd06 into main Jul 13, 2026
4 of 5 checks passed
@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: df50235d-ff4f-48aa-837f-67d1fed21e28

📥 Commits

Reviewing files that changed from the base of the PR and between 43c104f and 383aaa7.

📒 Files selected for processing (2)
  • crates/stubs/notebook-query/src/diagnostics.rs
  • crates/stubs/notebook-query/src/lib.rs

📝 Walkthrough

Walkthrough

Planner-gated imports in the notebook-query stub now resolve ThinkingStyle from lance_graph_planner::thinking::style; planner execution and diagnostics logic remain unchanged.

Changes

Planner import paths

Layer / File(s) Summary
Use canonical ThinkingStyle path
crates/stubs/notebook-query/src/diagnostics.rs, crates/stubs/notebook-query/src/lib.rs
Planner imports separate Planner and ThinkingStyle, importing ThinkingStyle from lance_graph_planner::thinking::style while retaining planner API imports.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested reviewers: claude

Poem

I’m a small rabbit, quick and bright,
I moved one path to make it right.
Planner hops, styles now align,
No logic changed in this design.
Nibble, compile, and all is fine!

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants