feat(parametric): add design tree viewer#140
Draft
techfowl wants to merge 1 commit intoAdam-CAD:masterfrom
Draft
feat(parametric): add design tree viewer#140techfowl wants to merge 1 commit intoAdam-CAD:masterfrom
techfowl wants to merge 1 commit intoAdam-CAD:masterfrom
Conversation
|
@techfowl is attempting to deploy a commit to the Adam Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a lightweight design tree for annotated parametric OpenSCAD artifacts.
The viewer now includes a collapsible design-tree drawer. Selecting a node filters linked parameter controls on desktop and mobile. Generated and edited artifacts also populate
designTreemetadata by parsing@cadam-nodecomments.Closes #139
Related to #62
What changed
DesignNodeartifact metadata.@cadam-nodecomment parsing inshared/designTree.ts.Out of scope
This PR does not implement mesh/viewport click selection. That requires node-to-geometry mapping from generated source to compiled mesh output and should be handled separately.
Test plan
npm run typechecknpm run lint— passes with existing warnings in unrelated filesnpm run buildnpm run lint:supabaseManual checks still needed before marking ready for review:
Summary by cubic
Adds a design tree viewer for annotated OpenSCAD models. Selecting a node filters parameters, and artifacts now include
designTreemetadata parsed from@cadam-nodecomments.@cadam-nodecomments intoDesignNodes in@shared/designTreeand attachdesignTreeto artifacts.designTree.Written for commit 4b3fbdc. Summary will update on new commits.