feat(ui): add dark/light/system theme support with toggle#100
Open
davidszp wants to merge 3 commits intoAdembc:mainfrom
Open
feat(ui): add dark/light/system theme support with toggle#100davidszp wants to merge 3 commits intoAdembc:mainfrom
davidszp wants to merge 3 commits intoAdembc:mainfrom
Conversation
- Add Theme struct with Dark and Light presets in theme.go - Add 'system' theme that auto-detects OS preference: - Linux: freedesktop portal (gdbus) - macOS: defaults read AppleInterfaceStyle - Windows: registry AppsUseLightTheme - Replace all hardcoded colors with CurrentTheme.* references - Add 'T' keyboard shortcut to cycle themes (dark → light → system) - Persist theme preference in ~/.lazyssh/metadata.json - Support backward compatibility with old metadata format - Add settings infrastructure (GetTheme/SaveTheme) to service layer - Add tests for theme and settings functionality
Separate alias text color from keyboard hint color for independent styling.
- Watch for OS theme changes when "system" mode is selected - Linux: event-driven via gdbus monitor (instant) - macOS: polling-based detection (2s interval) - Windows: stub implementation (detection only, no live updates) - Improve light theme VersionTag/CommitTag contrast
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tto cycle themes: dark → light → system → dark~/.lazyssh/metadata.jsonChanges
Themestruct centralizes all UI colors (tcell + hex markup)CurrentTheme.*referencesTest plan
make build-all)Tkey, verify UI updatesmetadata.jsonfiles still work