Update unit tests: add BillingService/CollaborationGateway mocks and adjust app greeting#1
Draft
Adityavanjre wants to merge 1 commit into
Draft
Update unit tests: add BillingService/CollaborationGateway mocks and adjust app greeting#1Adityavanjre wants to merge 1 commit into
Adityavanjre wants to merge 1 commit into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment Tip You can get early access to new features in CodeRabbit.Enable the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
BillingServiceprovider withgetPlanByTenantandcheckQuotastubs toledger.service.spec.tssoLedgerServicetests satisfy new constructor dependencies.AppControllerspec expectation string inapp.controller.spec.tstoNexus ERP API Gateway is Operationalto match the current status message.CollaborationGatewaywithbroadcastCommentAddedandbroadcastCommentDeletedtoaudit-collab-001.spec.tsand registered it in the testing module to satisfyCollaborationServicedependencies, and added a debugconsole.login the delete comment test to emit the actual error message on failure.Testing
yarn test), focusing onledger.service.spec.ts,app.controller.spec.ts, andaudit-collab-001.spec.ts, and the updated tests completed successfully.BadRequestExceptionis thrown.Codex Task