Skip to content

Stage #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BaskarMitrah wants to merge 3 commits into from
Closed

Stage #583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e109532
fix : code line issue
BaskarMitrah Apr 1, 2026
5d28511
changed in inlinealert
BaskarMitrah Apr 1, 2026
68456b0
added semicolon at end
BaskarMitrah Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion hlx_statics/blocks/inlinealert/inlinealert.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import decoratePreformattedCode from '../../components/code.js';
import {
createTag,
} from '../../scripts/lib-adobeio.js';
Expand Down Expand Up @@ -42,7 +43,7 @@ export function getVariant(classList) {
export default async function decorate(block) {

block.classList.add('spectrum-InLineAlert');
const slots = block?.getAttribute('data-slots')?.split(',');
const slots = block?.getAttribute('data-slots')?.split(',').map(slot => slot.trim());
const classVariant = getVariant(block.classList);

block.classList.add(classVariant.class);
Expand All @@ -51,6 +52,10 @@ export default async function decorate(block) {
// need to wrap content into p
block.querySelectorAll(':scope > div > div').forEach((div, i) =>{
const className = slots?.[i] === 'heading' ? 'spectrum-InLineAlert-header' : 'spectrum-InLineAlert-content';
const isCodeSlot = slots?.[i] === 'code';
if (isCodeSlot) {
decoratePreformattedCode(div);
}
const inlineP = createTag('p', { class: className });
inlineP.innerHTML = div.innerHTML;
block.appendChild(inlineP);
Expand Down
4 changes: 2 additions & 2 deletions hlx_statics/components/code.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ function applyDataAttributesFromCodeClasses(pre, code) {
}

export default function decoratePreformattedCode(block) {
const pre = block.querySelector('pre');
const pre = block.querySelector('pre') || (block.tagName === 'PRE' && block) || null;
const code = block.querySelector('code');

applyDataAttributesFromCodeClasses(pre, code);
Expand Down Expand Up @@ -161,7 +161,7 @@ export default function decoratePreformattedCode(block) {
code && processClasses(code);
}

if (pre?.classList.contains("disableLineNumbers")) {
if (pre?.classList.contains('disableLineNumbers')) {
pre?.classList.add('no-line-numbers');
}
else {
Expand Down
Loading