Skip to content

[negativebalancewarningwebhooks] Code generation: update services and models#1779

Closed
AdyenAutomationBot wants to merge 1 commit intomainfrom
sdk-automation/negativebalancewarningwebhooks
Closed

[negativebalancewarningwebhooks] Code generation: update services and models#1779
AdyenAutomationBot wants to merge 1 commit intomainfrom
sdk-automation/negativebalancewarningwebhooks

Conversation

@AdyenAutomationBot
Copy link
Copy Markdown
Collaborator

This PR contains the automated changes for the negativebalancewarningwebhooks service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

@AdyenAutomationBot AdyenAutomationBot requested review from a team as code owners March 9, 2026 13:31
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request delivers an automated update to the negativebalancewarningwebhooks service, reflecting recent changes in the underlying OpenAPI specification. The primary impact is a significant restructuring of the generated Java model classes, which have been moved to a more centralized com.adyen.model.java package. Concurrently, these models now incorporate advanced functionality for explicit null serialization, allowing for precise control over JSON output. This update also includes the removal of a dedicated webhook handler, streamlining the service's architecture.

Highlights

  • Package Refactoring: Several model classes were renamed and moved from a service-specific package (negativebalancewarningwebhooks) to a more general com.adyen.model.java package.
  • Explicit Null Serialization: New fields and methods were introduced in multiple model classes to enable explicit serialization of null values in JSON payloads, improving control over API responses.
  • Handler Removal: The NegativeBalanceWarningWebhooksHandler.java file was removed, indicating a potential change in how these webhooks are processed or handled.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • src/main/java/com/adyen/model/java/AbstractOpenApiSchema.java
    • Renamed from src/main/java/com/adyen/model/negativebalancewarningwebhooks/AbstractOpenApiSchema.java.
    • Updated package declaration to com.adyen.model.java.
  • src/main/java/com/adyen/model/java/Amount.java
    • Renamed from src/main/java/com/adyen/model/negativebalancewarningwebhooks/Amount.java.
    • Updated package declaration to com.adyen.model.java.
    • Added JsonAnyGetter and JsonIgnore imports.
    • Introduced isSetCurrency, isSetValue, and includeNullValues fields for explicit null serialization.
    • Modified builder and setter methods to track explicitly set fields.
    • Updated equals and hashCode methods to include new isSet fields.
    • Added getExplicitNulls and addIfNull methods to handle explicit null serialization.
  • src/main/java/com/adyen/model/java/NegativeBalanceCompensationWarningNotificationData.java
    • Renamed from src/main/java/com/adyen/model/negativebalancewarningwebhooks/NegativeBalanceCompensationWarningNotificationData.java.
    • Updated package declaration to com.adyen.model.java.
    • Added JsonAnyGetter and JsonIgnore imports.
    • Introduced isSet fields for all properties and includeNullValues for explicit null serialization.
    • Modified builder and setter methods to track explicitly set fields.
    • Updated equals and hashCode methods to include new isSet fields.
    • Added getExplicitNulls and addIfNull methods to handle explicit null serialization.
  • src/main/java/com/adyen/model/java/NegativeBalanceCompensationWarningNotificationRequest.java
    • Renamed from src/main/java/com/adyen/model/negativebalancewarningwebhooks/NegativeBalanceCompensationWarningNotificationRequest.java.
    • Updated package declaration to com.adyen.model.java.
    • Added JsonAnyGetter and JsonIgnore imports.
    • Introduced isSet fields for all properties and includeNullValues for explicit null serialization.
    • Modified builder and setter methods to track explicitly set fields.
    • Updated equals and hashCode methods to include new isSet fields.
    • Added getExplicitNulls and addIfNull methods to handle explicit null serialization.
  • src/main/java/com/adyen/model/java/Resource.java
    • Renamed from src/main/java/com/adyen/model/negativebalancewarningwebhooks/Resource.java.
    • Updated package declaration to com.adyen.model.java.
    • Added JsonAnyGetter and JsonIgnore imports.
    • Introduced isSet fields for all properties and includeNullValues for explicit null serialization.
    • Modified builder and setter methods to track explicitly set fields.
    • Updated equals and hashCode methods to include new isSet fields.
    • Added getExplicitNulls and addIfNull methods to handle explicit null serialization.
  • src/main/java/com/adyen/model/java/ResourceReference.java
    • Renamed from src/main/java/com/adyen/model/negativebalancewarningwebhooks/ResourceReference.java.
    • Updated package declaration to com.adyen.model.java.
    • Added JsonAnyGetter and JsonIgnore imports.
    • Introduced isSet fields for all properties and includeNullValues for explicit null serialization.
    • Modified builder and setter methods to track explicitly set fields.
    • Updated equals and hashCode methods to include new isSet fields.
    • Added getExplicitNulls and addIfNull methods to handle explicit null serialization.
  • src/main/java/com/adyen/model/negativebalancewarningwebhooks/JSON.java
    • Updated package declaration from com.adyen.model.negativebalancewarningwebhooks to com.adyen.model.java.
  • src/main/java/com/adyen/model/negativebalancewarningwebhooks/NegativeBalanceWarningWebhooksHandler.java
    • Removed the NegativeBalanceWarningWebhooksHandler file.
Activity
  • This is an automated pull request, and no human activity has been recorded yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, part of an automated code generation process, refactors several model classes from com.adyen.model.negativebalancewarningwebhooks to a more generic com.adyen.model.java package. It also introduces a mechanism for explicit serialization of null values by adding isSet... flags and related logic to the models.

While the changes are mostly consistent, I've identified a couple of critical issues that will break the build:

  1. The NegativeBalanceWarningWebhooksHandler class is removed, but its usage in BalancePlatformWebhooksTest is not updated.
  2. The JSON.java file has its package declaration changed without the file being moved, leading to a path-package mismatch.

Additionally, I've suggested a minor improvement in the equals methods for better performance and code style. Please see the detailed comments for each issue.

@@ -1,4 +1,4 @@
package com.adyen.model.negativebalancewarningwebhooks;
package com.adyen.model.java;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The package declaration com.adyen.model.java does not match the file path src/main/java/com/adyen/model/negativebalancewarningwebhooks/JSON.java. This will cause a compilation error. This file should be moved to src/main/java/com/adyen/model/java/JSON.java to align with its new package and the refactoring of other models.

@@ -1,83 +0,0 @@
/*
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This file is being removed, but src/test/java/com/adyen/webhooks/BalancePlatformWebhooksTest.java still has a dependency on it, which will cause the build to fail. Please update the test to remove the dependency on NegativeBalanceWarningWebhooksHandler. The testNegativeBalanceCompensationWarning test can likely be updated to use NegativeBalanceCompensationWarningNotificationRequest.fromJson(json) directly.

Comment on lines 163 to +166
return Objects.equals(this.currency, amount.currency)
&& Objects.equals(this.value, amount.value);
&& Objects.equals(this.isSetCurrency, amount.isSetCurrency)
&& Objects.equals(this.value, amount.value)
&& Objects.equals(this.isSetValue, amount.isSetValue);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The equals method uses Objects.equals() for primitive boolean fields (isSetCurrency, isSetValue), which causes unnecessary autoboxing. It's more efficient and idiomatic to compare primitive booleans directly using ==.

This pattern is repeated in other model classes modified in this PR (e.g., NegativeBalanceCompensationWarningNotificationData, Resource, ResourceReference) and should be addressed there as well.

Suggested change
return Objects.equals(this.currency, amount.currency)
&& Objects.equals(this.value, amount.value);
&& Objects.equals(this.isSetCurrency, amount.isSetCurrency)
&& Objects.equals(this.value, amount.value)
&& Objects.equals(this.isSetValue, amount.isSetValue);
return Objects.equals(this.currency, amount.currency)
&& this.isSetCurrency == amount.isSetCurrency
&& Objects.equals(this.value, amount.value)
&& this.isSetValue == amount.isSetValue;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants