[negativebalancewarningwebhooks] Code generation: update services and models#1779
[negativebalancewarningwebhooks] Code generation: update services and models#1779AdyenAutomationBot wants to merge 1 commit intomainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers an automated update to the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request, part of an automated code generation process, refactors several model classes from com.adyen.model.negativebalancewarningwebhooks to a more generic com.adyen.model.java package. It also introduces a mechanism for explicit serialization of null values by adding isSet... flags and related logic to the models.
While the changes are mostly consistent, I've identified a couple of critical issues that will break the build:
- The
NegativeBalanceWarningWebhooksHandlerclass is removed, but its usage inBalancePlatformWebhooksTestis not updated. - The
JSON.javafile has its package declaration changed without the file being moved, leading to a path-package mismatch.
Additionally, I've suggested a minor improvement in the equals methods for better performance and code style. Please see the detailed comments for each issue.
| @@ -1,4 +1,4 @@ | |||
| package com.adyen.model.negativebalancewarningwebhooks; | |||
| package com.adyen.model.java; | |||
There was a problem hiding this comment.
The package declaration com.adyen.model.java does not match the file path src/main/java/com/adyen/model/negativebalancewarningwebhooks/JSON.java. This will cause a compilation error. This file should be moved to src/main/java/com/adyen/model/java/JSON.java to align with its new package and the refactoring of other models.
| @@ -1,83 +0,0 @@ | |||
| /* | |||
There was a problem hiding this comment.
This file is being removed, but src/test/java/com/adyen/webhooks/BalancePlatformWebhooksTest.java still has a dependency on it, which will cause the build to fail. Please update the test to remove the dependency on NegativeBalanceWarningWebhooksHandler. The testNegativeBalanceCompensationWarning test can likely be updated to use NegativeBalanceCompensationWarningNotificationRequest.fromJson(json) directly.
| return Objects.equals(this.currency, amount.currency) | ||
| && Objects.equals(this.value, amount.value); | ||
| && Objects.equals(this.isSetCurrency, amount.isSetCurrency) | ||
| && Objects.equals(this.value, amount.value) | ||
| && Objects.equals(this.isSetValue, amount.isSetValue); |
There was a problem hiding this comment.
The equals method uses Objects.equals() for primitive boolean fields (isSetCurrency, isSetValue), which causes unnecessary autoboxing. It's more efficient and idiomatic to compare primitive booleans directly using ==.
This pattern is repeated in other model classes modified in this PR (e.g., NegativeBalanceCompensationWarningNotificationData, Resource, ResourceReference) and should be addressed there as well.
| return Objects.equals(this.currency, amount.currency) | |
| && Objects.equals(this.value, amount.value); | |
| && Objects.equals(this.isSetCurrency, amount.isSetCurrency) | |
| && Objects.equals(this.value, amount.value) | |
| && Objects.equals(this.isSetValue, amount.isSetValue); | |
| return Objects.equals(this.currency, amount.currency) | |
| && this.isSetCurrency == amount.isSetCurrency | |
| && Objects.equals(this.value, amount.value) | |
| && this.isSetValue == amount.isSetValue; |
This PR contains the automated changes for the
negativebalancewarningwebhooksservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.