Skip to content

[acswebhooks] Code generation: update services and models#1783

Closed
AdyenAutomationBot wants to merge 1 commit intomainfrom
sdk-automation/acswebhooks
Closed

[acswebhooks] Code generation: update services and models#1783
AdyenAutomationBot wants to merge 1 commit intomainfrom
sdk-automation/acswebhooks

Conversation

@AdyenAutomationBot
Copy link
Copy Markdown
Collaborator

This PR contains the automated changes for the acswebhooks service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

@AdyenAutomationBot AdyenAutomationBot requested review from a team as code owners March 9, 2026 13:31
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request automates updates to the acswebhooks service, primarily focusing on a significant refactoring of its model classes. The changes involve the removal of a dedicated webhook handler and a broad package migration for all related models. Crucially, a new mechanism for explicit null serialization has been introduced, providing finer control over how null values are represented in JSON payloads.

Highlights

  • Removed AcsWebhooksHandler: The AcsWebhooksHandler class has been removed, indicating a refactoring or deprecation of its specific webhook handling mechanism.
  • Package Refactoring: All acswebhooks model classes have been moved from the com.adyen.model.acswebhooks package to the more general com.adyen.model.java package.
  • Explicit Null Serialization: New logic has been introduced across numerous model classes to support explicit null serialization in JSON payloads. This includes adding isSet flags for each property, an includeNullValues configuration, and a getExplicitNulls method to ensure intentional null values are correctly represented.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • src/main/java/com/adyen/model/acswebhooks/AbstractOpenApiSchema.java
    • Renamed package to com.adyen.model.java.
    • Introduced includeNullValues field and methods for explicit null serialization.
    • Updated equals and hashCode methods to include isSet flags.
  • src/main/java/com/adyen/model/acswebhooks/AcsWebhooksHandler.java
    • Removed the handler class.
  • src/main/java/com/adyen/model/acswebhooks/Amount.java
    • Renamed package to com.adyen.model.java.
    • Added isSetCurrency and isSetValue boolean flags to track explicit setting of properties.
    • Introduced includeNullValues field and methods for explicit null serialization.
    • Implemented getExplicitNulls() method to include explicitly nullified fields in JSON output.
    • Updated equals and hashCode methods to account for the new isSet flags.
  • src/main/java/com/adyen/model/acswebhooks/AuthenticationDecision.java
    • Renamed package to com.adyen.model.java.
    • Added isSetStatus boolean flag to track explicit setting of the property.
    • Introduced includeNullValues field and methods for explicit null serialization.
    • Implemented getExplicitNulls() method to include explicitly nullified fields in JSON output.
    • Updated equals and hashCode methods to account for the new isSet flag.
  • src/main/java/com/adyen/model/acswebhooks/AuthenticationInfo.java
    • Renamed package to com.adyen.model.java.
    • Added isSetX boolean flags for all properties to track explicit setting.
    • Introduced includeNullValues field and methods for explicit null serialization.
    • Implemented getExplicitNulls() method to include explicitly nullified fields in JSON output.
    • Updated equals and hashCode methods to account for the new isSet flags.
  • src/main/java/com/adyen/model/acswebhooks/AuthenticationNotificationData.java
    • Renamed package to com.adyen.model.java.
    • Added isSetX boolean flags for all properties to track explicit setting.
    • Introduced includeNullValues field and methods for explicit null serialization.
    • Implemented getExplicitNulls() method to include explicitly nullified fields in JSON output.
    • Updated equals and hashCode methods to account for the new isSet flags.
  • src/main/java/com/adyen/model/acswebhooks/AuthenticationNotificationRequest.java
    • Renamed package to com.adyen.model.java.
    • Added isSetX boolean flags for all properties to track explicit setting.
    • Introduced includeNullValues field and methods for explicit null serialization.
    • Implemented getExplicitNulls() method to include explicitly nullified fields in JSON output.
    • Updated equals and hashCode methods to account for the new isSet flags.
  • src/main/java/com/adyen/model/acswebhooks/BalancePlatformNotificationResponse.java
    • Renamed package to com.adyen.model.java.
    • Added isSetNotificationResponse boolean flag to track explicit setting of the property.
    • Introduced includeNullValues field and methods for explicit null serialization.
    • Implemented getExplicitNulls() method to include explicitly nullified fields in JSON output.
    • Updated equals and hashCode methods to account for the new isSet flag.
  • src/main/java/com/adyen/model/acswebhooks/ChallengeInfo.java
    • Renamed package to com.adyen.model.java.
    • Added isSetX boolean flags for all properties to track explicit setting.
    • Introduced includeNullValues field and methods for explicit null serialization.
    • Implemented getExplicitNulls() method to include explicitly nullified fields in JSON output.
    • Updated equals and hashCode methods to account for the new isSet flags.
  • src/main/java/com/adyen/model/acswebhooks/JSON.java
    • Updated package declaration to com.adyen.model.java.
  • src/main/java/com/adyen/model/acswebhooks/Purchase.java
    • Renamed package to com.adyen.model.java.
    • Added isSetX boolean flags for all properties to track explicit setting.
    • Introduced includeNullValues field and methods for explicit null serialization.
    • Implemented getExplicitNulls() method to include explicitly nullified fields in JSON output.
    • Updated equals and hashCode methods to account for the new isSet flags.
  • src/main/java/com/adyen/model/acswebhooks/PurchaseInfo.java
    • Renamed package to com.adyen.model.java.
    • Added isSetX boolean flags for all properties to track explicit setting.
    • Introduced includeNullValues field and methods for explicit null serialization.
    • Implemented getExplicitNulls() method to include explicitly nullified fields in JSON output.
    • Updated equals and hashCode methods to account for the new isSet flags.
  • src/main/java/com/adyen/model/acswebhooks/RelayedAuthenticationRequest.java
    • Renamed package to com.adyen.model.java.
    • Added isSetX boolean flags for all properties to track explicit setting.
    • Introduced includeNullValues field and methods for explicit null serialization.
    • Implemented getExplicitNulls() method to include explicitly nullified fields in JSON output.
    • Updated equals and hashCode methods to account for the new isSet flags.
  • src/main/java/com/adyen/model/acswebhooks/RelayedAuthenticationResponse.java
    • Renamed package to com.adyen.model.java.
    • Added isSetAuthenticationDecision boolean flag to track explicit setting of the property.
    • Introduced includeNullValues field and methods for explicit null serialization.
    • Implemented getExplicitNulls() method to include explicitly nullified fields in JSON output.
    • Updated equals and hashCode methods to account for the new isSet flag.
  • src/main/java/com/adyen/model/acswebhooks/Resource.java
    • Renamed package to com.adyen.model.java.
    • Added isSetX boolean flags for all properties to track explicit setting.
    • Introduced includeNullValues field and methods for explicit null serialization.
    • Implemented getExplicitNulls() method to include explicitly nullified fields in JSON output.
    • Updated equals and hashCode methods to account for the new isSet flags.
  • src/main/java/com/adyen/model/acswebhooks/ServiceError.java
    • Renamed package to com.adyen.model.java.
    • Added isSetX boolean flags for all properties to track explicit setting.
    • Introduced includeNullValues field and methods for explicit null serialization.
    • Implemented getExplicitNulls() method to include explicitly nullified fields in JSON output.
    • Updated equals and hashCode methods to account for the new isSet flags.
Activity
  • This pull request was automatically generated by AdyenAutomationBot to update services and models.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is an automated code generation task to update services and models for acswebhooks, including refactoring model classes, removing AcsWebhooksHandler.java, and implementing explicit null serialization. While a security audit found no vulnerabilities related to injection, insecure data handling, or broken access control, a critical file path issue was identified that will likely break the build.

@@ -1,4 +1,4 @@
package com.adyen.model.acswebhooks;
package com.adyen.model.java;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The package for this file has been updated to com.adyen.model.java, but the file itself was not moved or renamed from src/main/java/com/adyen/model/acswebhooks/JSON.java. This mismatch between the package declaration and the file path will cause a compilation error. To fix this, the file should be moved to src/main/java/com/adyen/model/java/JSON.java to match the new package structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants