[payout] Code generation: update services and models#1787
[payout] Code generation: update services and models#1787AdyenAutomationBot wants to merge 1 commit intomainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request systematically updates the generated code for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request appears to be an automated refactoring to move shared model classes from the com.adyen.model.payout package to a more generic com.adyen.model.java package. While most files have been correctly renamed and moved, there is a critical issue with JSON.java. Its package declaration was updated, but the file itself was not moved, which will lead to a compilation failure. This file needs to be moved to the correct directory to align with its new package structure.
| @@ -1,4 +1,4 @@ | |||
| package com.adyen.model.payout; | |||
| package com.adyen.model.java; | |||
There was a problem hiding this comment.
The package declaration has been updated to com.adyen.model.java, but the file has not been moved to the corresponding directory (src/main/java/com/adyen/model/java/). This mismatch between the package declaration and the file path will cause a compilation error. To fix this, the file should be moved from src/main/java/com/adyen/model/payout/JSON.java to src/main/java/com/adyen/model/java/JSON.java. It seems this file was missed during the automated refactoring, as other model files have been correctly moved.
This PR contains the automated changes for the
payoutservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.