[checkout] Code generation: update services and models#1791
Closed
AdyenAutomationBot wants to merge 1 commit intomainfrom
Closed
[checkout] Code generation: update services and models#1791AdyenAutomationBot wants to merge 1 commit intomainfrom
AdyenAutomationBot wants to merge 1 commit intomainfrom
Conversation
Contributor
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on a significant refactoring of the Java package structure for the checkout service's model classes. The change moves all model definitions from a service-specific package to a more generic Java model package, likely to centralize common models or align with a broader architectural standard. This is an automated update, ensuring the codebase remains synchronized with the latest API definitions. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request appears to be an automated refactoring to move model classes from the com.adyen.model.checkout package to a more generic com.adyen.model.java package. The changes are consistent across a large number of files. However, I found one critical issue where a file's package was updated without the corresponding file path change, which will lead to a compilation error. Please see the specific comment for details.
| @@ -1,4 +1,4 @@ | |||
| package com.adyen.model.checkout; | |||
| package com.adyen.model.java; | |||
Contributor
There was a problem hiding this comment.
The package declaration has been changed to com.adyen.model.java, but the file path appears to be unchanged (src/main/java/com/adyen/model/checkout/JSON.java). This will cause a compilation error as the package structure must match the directory structure in Java.
It seems this file was intended to be moved like the other model files in this PR, but was modified in-place instead of being renamed/moved. To fix the compilation error, this file should be moved to src/main/java/com/adyen/model/java/JSON.java.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the automated changes for the
checkoutservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.